mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Put the resolv.conf path in a variable instead of being hardcoded within lxc
This commit is contained in:
parent
e41fd24542
commit
1f9f5eed5d
3 changed files with 13 additions and 8 deletions
13
container.go
13
container.go
|
@ -33,13 +33,14 @@ type Container struct {
|
||||||
network *NetworkInterface
|
network *NetworkInterface
|
||||||
NetworkSettings *NetworkSettings
|
NetworkSettings *NetworkSettings
|
||||||
|
|
||||||
SysInitPath string
|
SysInitPath string
|
||||||
cmd *exec.Cmd
|
ResolvConfPath string
|
||||||
stdout *writeBroadcaster
|
|
||||||
stderr *writeBroadcaster
|
|
||||||
stdin io.ReadCloser
|
|
||||||
stdinPipe io.WriteCloser
|
|
||||||
|
|
||||||
|
cmd *exec.Cmd
|
||||||
|
stdout *writeBroadcaster
|
||||||
|
stderr *writeBroadcaster
|
||||||
|
stdin io.ReadCloser
|
||||||
|
stdinPipe io.WriteCloser
|
||||||
ptyMaster io.Closer
|
ptyMaster io.Closer
|
||||||
|
|
||||||
runtime *Runtime
|
runtime *Runtime
|
||||||
|
|
|
@ -78,7 +78,7 @@ lxc.mount.entry = devpts {{$ROOTFS}}/dev/pts devpts newinstance,ptmxmode=0666,no
|
||||||
lxc.mount.entry = {{.SysInitPath}} {{$ROOTFS}}/sbin/init none bind,ro 0 0
|
lxc.mount.entry = {{.SysInitPath}} {{$ROOTFS}}/sbin/init none bind,ro 0 0
|
||||||
|
|
||||||
# In order to get a working DNS environment, mount bind (ro) the host's /etc/resolv.conf into the container
|
# In order to get a working DNS environment, mount bind (ro) the host's /etc/resolv.conf into the container
|
||||||
lxc.mount.entry = /etc/resolv.conf {{$ROOTFS}}/etc/resolv.conf none bind,ro 0 0
|
lxc.mount.entry = {{.ResolvConfPath}} {{$ROOTFS}}/etc/resolv.conf none bind,ro 0 0
|
||||||
|
|
||||||
|
|
||||||
# drop linux capabilities (apply mainly to the user root in the container)
|
# drop linux capabilities (apply mainly to the user root in the container)
|
||||||
|
|
|
@ -82,6 +82,9 @@ func (runtime *Runtime) Create(config *Config) (*Container, error) {
|
||||||
if config.Hostname == "" {
|
if config.Hostname == "" {
|
||||||
config.Hostname = id[:12]
|
config.Hostname = id[:12]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
resolvConfPath := "/etc/resolv.conf"
|
||||||
|
|
||||||
container := &Container{
|
container := &Container{
|
||||||
// FIXME: we should generate the ID here instead of receiving it as an argument
|
// FIXME: we should generate the ID here instead of receiving it as an argument
|
||||||
Id: id,
|
Id: id,
|
||||||
|
@ -92,7 +95,8 @@ func (runtime *Runtime) Create(config *Config) (*Container, error) {
|
||||||
Image: img.Id, // Always use the resolved image id
|
Image: img.Id, // Always use the resolved image id
|
||||||
NetworkSettings: &NetworkSettings{},
|
NetworkSettings: &NetworkSettings{},
|
||||||
// FIXME: do we need to store this in the container?
|
// FIXME: do we need to store this in the container?
|
||||||
SysInitPath: sysInitPath,
|
SysInitPath: sysInitPath,
|
||||||
|
ResolvConfPath: resolvConfPath,
|
||||||
}
|
}
|
||||||
container.root = runtime.containerRoot(container.Id)
|
container.root = runtime.containerRoot(container.Id)
|
||||||
// Step 1: create the container directory.
|
// Step 1: create the container directory.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue