kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #10365 from cpuguy83/9981_fix_cannot_overwrite_nonbind_as_bind

Browse source 
Allow path from normal volume existing to overwrite in start Binds
This commit is contained in:
Jessie Frazelle 2015-03-23 10:43:02 -07:00
commit 1fe55b2f8b
2 changed files with 40 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
daemon/volumes.go
View file

@ -24,6 +24,7 @@ type Mount struct {
Writable bool Writable bool
copyData bool copyData bool
from *Container from *Container
isBind bool
} }
func (mnt *Mount) Export(resource string) (io.ReadCloser, error) { func (mnt *Mount) Export(resource string) (io.ReadCloser, error) {
@ -79,7 +80,7 @@ func (m *Mount) initialize() error {
if hostPath, exists := m.container.Volumes[m.MountToPath]; exists { if hostPath, exists := m.container.Volumes[m.MountToPath]; exists {
// If this is a bind-mount/volumes-from, maybe it was passed in at start instead of create // If this is a bind-mount/volumes-from, maybe it was passed in at start instead of create
// We need to make sure bind-mounts/volumes-from passed on start can override existing ones. // We need to make sure bind-mounts/volumes-from passed on start can override existing ones.
if !m.volume.IsBindMount && m.from == nil { if (!m.volume.IsBindMount && !m.isBind) && m.from == nil {
return nil return nil
} }
if m.volume.Path == hostPath { if m.volume.Path == hostPath {
@ -172,6 +173,7 @@ func (container *Container) parseVolumeMountConfig() (map[string]*Mount, error)
volume: vol, volume: vol,
MountToPath: mountToPath, MountToPath: mountToPath,
Writable: writable, Writable: writable,
isBind: true, // in case the volume itself is a normal volume, but is being mounted in as a bindmount here
} }
} }

37
integration-cli/docker_api_containers_test.go
View file

@ -516,3 +516,40 @@ func TestBuildApiDockerfileSymlink(t *testing.T) {
logDone("container REST API - check build w/bad Dockerfile symlink path") logDone("container REST API - check build w/bad Dockerfile symlink path")
} }
// #9981 - Allow a docker created volume (ie, one in /var/lib/docker/volumes) to be used to overwrite (via passing in Binds on api start) an existing volume
func TestPostContainerBindNormalVolume(t *testing.T) {
defer deleteAllContainers()
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "create", "-v", "/foo", "--name=one", "busybox"))
if err != nil {
t.Fatal(err, out)
}
fooDir, err := inspectFieldMap("one", "Volumes", "/foo")
if err != nil {
t.Fatal(err)
}
out, _, err = runCommandWithOutput(exec.Command(dockerBinary, "create", "-v", "/foo", "--name=two", "busybox"))
if err != nil {
t.Fatal(err, out)
}
bindSpec := map[string][]string{"Binds": {fooDir + ":/foo"}}
_, err = sockRequest("POST", "/containers/two/start", bindSpec)
if err != nil && !strings.Contains(err.Error(), "204 No Content") {
t.Fatal(err)
}
fooDir2, err := inspectFieldMap("two", "Volumes", "/foo")
if err != nil {
t.Fatal(err)
}
if fooDir2 != fooDir {
t.Fatal("expected volume path to be %s, got: %s", fooDir, fooDir2)
}
logDone("container REST API - can use path from normal volume as bind-mount to overwrite another volume")
}