diff --git a/daemon/cluster/swarm.go b/daemon/cluster/swarm.go index 5deb8a024d..2a97207f33 100644 --- a/daemon/cluster/swarm.go +++ b/daemon/cluster/swarm.go @@ -504,7 +504,8 @@ func validateAddr(addr string) (string, error) { } func initClusterSpec(node *swarmnode.Node, spec types.Spec) error { - ctx, _ := context.WithTimeout(context.Background(), 5*time.Second) + ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) + defer cancel() for conn := range node.ListenControlSocket(ctx) { if ctx.Err() != nil { return ctx.Err() diff --git a/pkg/ioutils/readers_test.go b/pkg/ioutils/readers_test.go index e009ab26f6..a32e661210 100644 --- a/pkg/ioutils/readers_test.go +++ b/pkg/ioutils/readers_test.go @@ -80,7 +80,8 @@ func (p *perpetualReader) Read(buf []byte) (n int, err error) { } func TestCancelReadCloser(t *testing.T) { - ctx, _ := context.WithTimeout(context.Background(), 100*time.Millisecond) + ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond) + defer cancel() cancelReadCloser := NewCancelReadCloser(ctx, ioutil.NopCloser(&perpetualReader{})) for { var buf [128]byte