kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

authz: remove and hide unused and local-only methods respectively

Browse source 
Signed-off-by: David Sheets <dsheets@docker.com>
This commit is contained in:
David Sheets 2017-06-13 12:12:42 +01:00
parent 7da3986297
commit 24264697c5
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
pkg/authorization/middleware.go
View file

@ -25,20 +25,12 @@ func NewMiddleware(names []string, pg plugingetter.PluginGetter) *Middleware {
} }
} }
// GetAuthzPlugins gets authorization plugins func (m *Middleware) getAuthzPlugins() []Plugin {
func (m *Middleware) GetAuthzPlugins() []Plugin {
m.mu.Lock() m.mu.Lock()
defer m.mu.Unlock() defer m.mu.Unlock()
return m.plugins return m.plugins
} }
// SetAuthzPlugins sets authorization plugins
func (m *Middleware) SetAuthzPlugins(plugins []Plugin) {
m.mu.Lock()
m.plugins = plugins
m.mu.Unlock()
}
// SetPlugins sets the plugin used for authorization // SetPlugins sets the plugin used for authorization
func (m *Middleware) SetPlugins(names []string) { func (m *Middleware) SetPlugins(names []string) {
m.mu.Lock() m.mu.Lock()
@ -62,7 +54,7 @@ func (m *Middleware) RemovePlugin(name string) {
// WrapHandler returns a new handler function wrapping the previous one in the request chain. // WrapHandler returns a new handler function wrapping the previous one in the request chain.
func (m *Middleware) WrapHandler(handler func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error) func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error { func (m *Middleware) WrapHandler(handler func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error) func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
return func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error { return func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
plugins := m.GetAuthzPlugins() plugins := m.getAuthzPlugins()
if len(plugins) == 0 { if len(plugins) == 0 {
return handler(ctx, w, r, vars) return handler(ctx, w, r, vars)
} }
@ -96,7 +88,7 @@ func (m *Middleware) WrapHandler(handler func(ctx context.Context, w http.Respon
// There's a chance that the authCtx.plugins was updated. One of the reasons // There's a chance that the authCtx.plugins was updated. One of the reasons
// this can happen is when an authzplugin is disabled. // this can happen is when an authzplugin is disabled.
plugins = m.GetAuthzPlugins() plugins = m.getAuthzPlugins()
if len(plugins) == 0 { if len(plugins) == 0 {
logrus.Debug("There are no authz plugins in the chain") logrus.Debug("There are no authz plugins in the chain")
return nil return nil