kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Do not call out to Google on init

Browse source 
The GCP logging driver is calling out to GCP cloud service on package
init.
This is regardless if you are using GCP logging or not.

This change makes this happen on the first invocation of a new GCP
logging driver instance instead.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff 2016-03-17 10:58:23 -04:00
parent 37a1fadae6
commit 24710fd3e2
1 changed files with 21 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
daemon/logger/gcplogs/gcplogging.go
View file

@ -2,6 +2,7 @@ package gcplogs
import ( import (
"fmt" "fmt"
"sync"
"sync/atomic" "sync/atomic"
"time" "time"
@ -26,7 +27,7 @@ var (
// The number of logs the gcplogs driver has dropped. // The number of logs the gcplogs driver has dropped.
droppedLogs uint64 droppedLogs uint64
onGCE = metadata.OnGCE() onGCE bool
// instance metadata populated from the metadata server if available // instance metadata populated from the metadata server if available
projectID string projectID string
@ -36,16 +37,6 @@ var (
) )
func init() { func init() {
if onGCE {
// These will fail on instances if the metadata service is
// down or the client is compiled with an API version that
// has been removed. Since these are not vital, let's ignore
// them and make their fields in the dockeLogEntry ,omitempty
projectID, _ = metadata.ProjectID()
zone, _ = metadata.Zone()
instanceName, _ = metadata.InstanceName()
instanceID, _ = metadata.InstanceID()
}
if err := logger.RegisterLogDriver(name, New); err != nil { if err := logger.RegisterLogDriver(name, New); err != nil {
logrus.Fatal(err) logrus.Fatal(err)
@ -84,11 +75,30 @@ type containerInfo struct {
Metadata map[string]string `json:"metadata,omitempty"` Metadata map[string]string `json:"metadata,omitempty"`
} }
var initGCPOnce sync.Once
func initGCP() {
initGCPOnce.Do(func() {
onGCE = metadata.OnGCE()
if onGCE {
// These will fail on instances if the metadata service is
// down or the client is compiled with an API version that
// has been removed. Since these are not vital, let's ignore
// them and make their fields in the dockeLogEntry ,omitempty
projectID, _ = metadata.ProjectID()
zone, _ = metadata.Zone()
instanceName, _ = metadata.InstanceName()
instanceID, _ = metadata.InstanceID()
}
})
}
// New creates a new logger that logs to Google Cloud Logging using the application // New creates a new logger that logs to Google Cloud Logging using the application
// default credentials. // default credentials.
// //
// See https://developers.google.com/identity/protocols/application-default-credentials // See https://developers.google.com/identity/protocols/application-default-credentials
func New(ctx logger.Context) (logger.Logger, error) { func New(ctx logger.Context) (logger.Logger, error) {
initGCP()
var project string var project string
if projectID != "" { if projectID != "" {