1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00

registry: remove TODO for removing localhost as insecure by default

While this was intended t be a stop-gap solution, it's been there for years and
users depend on this. It's also still complicated to secure _localhost_, so
by now, we'd probably have to be realistic, and consider this to be "permanent".

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2022-02-26 01:06:18 +01:00
parent d9261561f9
commit 2bcf4628a7
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C

View file

@ -161,11 +161,8 @@ func (config *serviceConfig) LoadMirrors(mirrors []string) error {
// LoadInsecureRegistries loads insecure registries to config // LoadInsecureRegistries loads insecure registries to config
func (config *serviceConfig) LoadInsecureRegistries(registries []string) error { func (config *serviceConfig) LoadInsecureRegistries(registries []string) error {
// Localhost is by default considered as an insecure registry // Localhost is by default considered as an insecure registry. This is a
// This is a stop-gap for people who are running a private registry on localhost (especially on Boot2docker). // stop-gap for people who are running a private registry on localhost.
//
// TODO: should we deprecate this once it is easier for people to set up a TLS registry or change
// daemon flags on boot2docker?
registries = append(registries, "127.0.0.0/8") registries = append(registries, "127.0.0.0/8")
// Store original InsecureRegistryCIDRs and IndexConfigs // Store original InsecureRegistryCIDRs and IndexConfigs