kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #32407 from dnephin/fix-rw-mode-compose-files

Browse source 
Support rw as a volume option in compose file
This commit is contained in:
Brian Goff 2017-04-06 16:24:20 -04:00 committed by GitHub
commit 30cdabd13f
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/compose/loader/volume.go
View file

@ -70,6 +70,8 @@ func populateFieldFromBuffer(char rune, buffer []rune, volume *types.ServiceVolu
switch option {
case "ro":
volume.ReadOnly = true
case "rw":
volume.ReadOnly = false
case "nocopy":
volume.Volume = &types.ServiceVolumeVolume{NoCopy: true}
default:

14
cli/compose/loader/volume_test.go
View file

@ -132,3 +132,17 @@ func TestParseVolumeWithReadOnly(t *testing.T) {
assert.DeepEqual(t, volume, expected)
}
}
func TestParseVolumeWithRW(t *testing.T) {
for _, path := range []string{"./foo", "/home/user"} {
volume, err := parseVolume(path + ":/target:rw")
expected := types.ServiceVolumeConfig{
Type: "bind",
Source: path,
Target: "/target",
ReadOnly: false,
}
assert.NilError(t, err)
assert.DeepEqual(t, volume, expected)
}
}