From 32f4fdfb5c8846922302c20fdcab973227eb9bd6 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 15 Jul 2019 17:09:20 +0200 Subject: [PATCH] errdefs: remove unneeded recursive calls The `statusCodeFromGRPCError` and `statusCodeFromDistributionError` helpers are used by `GetHTTPErrorStatusCode`, which already recurses if the error implements the `Causer` interface. Signed-off-by: Sebastiaan van Stijn --- errdefs/http_helpers.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/errdefs/http_helpers.go b/errdefs/http_helpers.go index ac9bf6d33e..faebc6a6d3 100644 --- a/errdefs/http_helpers.go +++ b/errdefs/http_helpers.go @@ -136,9 +136,6 @@ func statusCodeFromGRPCError(err error) int { case codes.Unavailable: // code 14 return http.StatusServiceUnavailable default: - if e, ok := err.(causer); ok { - return statusCodeFromGRPCError(e.Cause()) - } // codes.Canceled(1) // codes.Unknown(2) // codes.DeadlineExceeded(4) @@ -163,10 +160,6 @@ func statusCodeFromDistributionError(err error) int { } case errcode.ErrorCoder: return errs.ErrorCode().Descriptor().HTTPStatusCode - default: - if e, ok := err.(causer); ok { - return statusCodeFromDistributionError(e.Cause()) - } } return http.StatusInternalServerError }