From 36e7a8b16870d421f1a7296fac04814c956813ca Mon Sep 17 00:00:00 2001 From: Toshiaki Makita Date: Wed, 2 Sep 2015 16:19:19 +0900 Subject: [PATCH] Add TestEndToEndErrorMessage Test if error messages from daemon are not empty strings. Confirmed it fails without af323c7. --- FAIL: TestEndToEndErrorMessage (0.03s) api_test.go:2266: Empty response error message. Signed-off-by: Toshiaki Makita --- libnetwork/api/api_test.go | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/libnetwork/api/api_test.go b/libnetwork/api/api_test.go index d855a8d1a0..b4be54e884 100644 --- a/libnetwork/api/api_test.go +++ b/libnetwork/api/api_test.go @@ -2239,6 +2239,34 @@ func TestEndToEnd(t *testing.T) { } } +func TestEndToEndErrorMessage(t *testing.T) { + defer osl.SetupTestOSContext(t)() + + rsp := newWriter() + + c, err := libnetwork.New() + if err != nil { + t.Fatal(err) + } + handleRequest := NewHTTPHandler(c) + + body := []byte{} + lr := newLocalReader(body) + req, err := http.NewRequest("POST", "/v1.19/networks", lr) + if err != nil { + t.Fatal(err) + } + handleRequest(rsp, req) + + if len(rsp.body) == 0 { + t.Fatalf("Empty response body.") + } + empty := []byte("\"\"") + if bytes.Equal(empty, bytes.TrimSpace(rsp.body)) { + t.Fatalf("Empty response error message.") + } +} + type bre struct{} func (b *bre) Error() string {