kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Do not ignore error from syscall.Unmount

Browse source 
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
This commit is contained in:
Alexander Morozov 2015-11-02 14:40:29 -08:00
parent beeec6d103
commit 3f10bdf100
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
daemon/container.go
View file

@ -1168,7 +1168,9 @@ func (container *Container) unmountVolumes(forceSyscall bool) error {
for _, volumeMount := range volumeMounts {
if forceSyscall {
system.Unmount(volumeMount.Destination)
if err := system.Unmount(volumeMount.Destination); err != nil {
logrus.Warnf("%s unmountVolumes: Failed to force umount %v", container.ID, err)
}
}
if volumeMount.Volume != nil {

4
pkg/system/syscall_unix.go
View file

@ -6,6 +6,6 @@ import "syscall"
// Unmount is a platform-specific helper function to call
// the unmount syscall.
func Unmount(dest string) {
syscall.Unmount(dest, 0)
func Unmount(dest string) error {
return syscall.Unmount(dest, 0)
}

3
pkg/system/syscall_windows.go
View file

@ -2,5 +2,6 @@ package system
// Unmount is a platform-specific helper function to call
// the unmount syscall. Not supported on Windows
func Unmount(dest string) {
func Unmount(dest string) error {
return nil
}