kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Check size of keys slice

Browse source 
If not enough keys are provided to SetKeys, this may cause a panic. This
should not cause problems with the current integration in Docker 1.12.0,
but the panic might happen loading data created by an earlier version,
or data that is corrupted somehow. Add a length check to be defensive.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
This commit is contained in:
Aaron Lehmann 2016-08-02 18:34:10 -07:00
parent c9eb73fccc
commit 3f542419ac
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
libnetwork/agent.go
View file

@ -136,10 +136,16 @@ func (c *controller) handleKeyChange(keys []*types.EncryptionKey) error {
} }
} }
key, tag := c.getPrimaryKeyTag(subsysGossip) key, tag, err := c.getPrimaryKeyTag(subsysGossip)
if err != nil {
return err
}
a.networkDB.SetPrimaryKey(key) a.networkDB.SetPrimaryKey(key)
key, tag = c.getPrimaryKeyTag(subsysIPSec) key, tag, err = c.getPrimaryKeyTag(subsysIPSec)
if err != nil {
return err
}
drvEnc.Primary = key drvEnc.Primary = key
drvEnc.PrimaryTag = tag drvEnc.PrimaryTag = tag
@ -289,9 +295,9 @@ func (c *controller) getKeys(subsys string) ([][]byte, []uint64) {
return keys, tags return keys, tags
} }
// getPrimaryKeyTag returns the primary key for a given subsytem from the // getPrimaryKeyTag returns the primary key for a given subsystem from the
// list of sorted key and the associated tag // list of sorted key and the associated tag
func (c *controller) getPrimaryKeyTag(subsys string) ([]byte, uint64) { func (c *controller) getPrimaryKeyTag(subsys string) ([]byte, uint64, error) {
sort.Sort(ByTime(c.keys)) sort.Sort(ByTime(c.keys))
keys := []*types.EncryptionKey{} keys := []*types.EncryptionKey{}
for _, key := range c.keys { for _, key := range c.keys {
@ -299,7 +305,10 @@ func (c *controller) getPrimaryKeyTag(subsys string) ([]byte, uint64) {
keys = append(keys, key) keys = append(keys, key)
} }
} }
return keys[1].Key, keys[1].LamportTime if len(keys) < 2 {
return nil, 0, fmt.Errorf("primary key for subsystem %s not found", subsys)
}
return keys[1].Key, keys[1].LamportTime, nil
} }
func (c *controller) agentInit(bindAddrOrInterface, advertiseAddr string) error { func (c *controller) agentInit(bindAddrOrInterface, advertiseAddr string) error {