From 37466cc8c85ccbdade57463ae2aacac638002f8a Mon Sep 17 00:00:00 2001 From: timfeirg Date: Mon, 15 Aug 2016 19:33:56 +0800 Subject: [PATCH] expose RemovalInProgress in StateString #25652 Signed-off-by: timfeirg --- container/state.go | 5 +++++ contrib/completion/bash/docker | 2 +- contrib/completion/zsh/_docker | 2 +- docs/reference/api/docker_remote_api.md | 2 ++ docs/reference/api/docker_remote_api_v1.25.md | 2 +- docs/reference/commandline/ps.md | 6 +++--- 6 files changed, 13 insertions(+), 6 deletions(-) diff --git a/container/state.go b/container/state.go index 081d91f41e..d9a77052a5 100644 --- a/container/state.go +++ b/container/state.go @@ -86,6 +86,10 @@ func (s *State) StateString() string { return "running" } + if s.RemovalInProgress { + return "removing" + } + if s.Dead { return "dead" } @@ -101,6 +105,7 @@ func (s *State) StateString() string { func IsValidStateString(s string) bool { if s != "paused" && s != "restarting" && + s != "removing" && s != "running" && s != "dead" && s != "created" && diff --git a/contrib/completion/bash/docker b/contrib/completion/bash/docker index 6d7278bc57..197f8977e9 100644 --- a/contrib/completion/bash/docker +++ b/contrib/completion/bash/docker @@ -2182,7 +2182,7 @@ _docker_ps() { return ;; status) - COMPREPLY=( $( compgen -W "created dead exited paused restarting running" -- "${cur##*=}" ) ) + COMPREPLY=( $( compgen -W "created dead exited paused restarting running removing" -- "${cur##*=}" ) ) return ;; volume) diff --git a/contrib/completion/zsh/_docker b/contrib/completion/zsh/_docker index 733477cbb9..4000652dd2 100644 --- a/contrib/completion/zsh/_docker +++ b/contrib/completion/zsh/_docker @@ -340,7 +340,7 @@ __docker_complete_ps_filters() { __docker_networks && ret=0 ;; (status) - status_opts=('created' 'dead' 'exited' 'paused' 'restarting' 'running') + status_opts=('created' 'dead' 'exited' 'paused' 'restarting' 'running' 'removing') _describe -t status-filter-opts "Status Filter Options" status_opts && ret=0 ;; (volume) diff --git a/docs/reference/api/docker_remote_api.md b/docs/reference/api/docker_remote_api.md index deafb1fe84..42fc22546e 100644 --- a/docs/reference/api/docker_remote_api.md +++ b/docs/reference/api/docker_remote_api.md @@ -117,6 +117,8 @@ This section lists each version from latest to oldest. Each listing includes a [Docker Remote API v1.25](docker_remote_api_v1.25.md) documentation * `POST /containers/create` now takes `AutoRemove` in HostConfig, to enable auto-removal of the container on daemon side when the container's process exits. +* `GET /containers/json` and `GET /containers/(id or name)/json` now return `"removing"` as a value for the `State.Status` field if the container is being removed. Previously, "exited" was returned as status. +* `GET /containers/json` now accepts `removing` as a valid value for the `status` filter. ### v1.24 API changes diff --git a/docs/reference/api/docker_remote_api_v1.25.md b/docs/reference/api/docker_remote_api_v1.25.md index 72839ba9d4..5c83d642b4 100644 --- a/docs/reference/api/docker_remote_api_v1.25.md +++ b/docs/reference/api/docker_remote_api_v1.25.md @@ -226,7 +226,7 @@ List containers sizes - **filters** - a JSON encoded value of the filters (a `map[string][]string`) to process on the containers list. Available filters: - `exited=`; -- containers with exit code of `` ; - - `status=`(`created`|`restarting`|`running`|`paused`|`exited`|`dead`) + - `status=`(`created`|`restarting`|`running`|`removing`|`paused`|`exited`|`dead`) - `label=key` or `label="key=value"` of a container label - `isolation=`(`default`|`process`|`hyperv`) (Windows daemon only) - `ancestor`=(`[:]`, `` or ``) diff --git a/docs/reference/commandline/ps.md b/docs/reference/commandline/ps.md index 185cce16f3..1f3ceb3799 100644 --- a/docs/reference/commandline/ps.md +++ b/docs/reference/commandline/ps.md @@ -20,7 +20,7 @@ Options: -f, --filter value Filter output based on conditions provided (default []) - exited= an exit code of - label= or label== - - status=(created|restarting|running|paused|exited) + - status=(created|restarting|removing|running|paused|exited) - name= a container's name - id= a container's ID - before=(|) @@ -68,7 +68,7 @@ The currently supported filters are: * label (`label=` or `label==`) * name (container's name) * exited (int - the code of exited containers. Only useful with `--all`) -* status (created|restarting|running|paused|exited|dead) +* status (created|restarting|running|removing|paused|exited|dead) * ancestor (`[:]`, `` or ``) - filters containers that were created from the given image or a descendant. * before (container's id or name) - filters containers created before given id or name * since (container's id or name) - filters containers created since given id or name @@ -158,7 +158,7 @@ Any of these events result in a `137` status: #### Status The `status` filter matches containers by status. You can filter using -`created`, `restarting`, `running`, `paused`, `exited` and `dead`. For example, +`created`, `restarting`, `running`, `removing`, `paused`, `exited` and `dead`. For example, to filter for `running` containers: ```bash