kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

API-client: remove unused ContainerListOptions.Quiet field

Browse source 
This option was originally added in d05aa418b0,
and moved in 8b15839ee8 (after which it temporarily
went to the docker/engine-api repository, and was brought back in this repository
in 91e197d614).

However, it looks like this field was never used; the API always returns the standard
information, and the "--quiet" option for `docker ps` is implemented on the CLI
side, which uses different formatting when setting this option;
2ec468e284/api/client/ps.go (L73-L79)

This patch removes the unused field,

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2021-02-28 16:03:54 +01:00
parent 5a82cee6d4
commit 4d3f64da63
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
2 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
api/types/client.go
View file

@ -59,7 +59,6 @@ type ContainerExecInspect struct {
// ContainerListOptions holds parameters to list containers with. // ContainerListOptions holds parameters to list containers with.
type ContainerListOptions struct { type ContainerListOptions struct {
Quiet bool
Size bool Size bool
All bool All bool
Latest bool Latest bool

4
testutil/environment/clean.go
View file

@ -50,7 +50,6 @@ func getPausedContainers(ctx context.Context, t testing.TB, client client.Contai
filter.Add("status", "paused") filter.Add("status", "paused")
containers, err := client.ContainerList(ctx, types.ContainerListOptions{ containers, err := client.ContainerList(ctx, types.ContainerListOptions{
Filters: filter, Filters: filter,
Quiet: true,
All: true, All: true,
}) })
assert.Check(t, err, "failed to list containers") assert.Check(t, err, "failed to list containers")
@ -85,8 +84,7 @@ func deleteAllContainers(t testing.TB, apiclient client.ContainerAPIClient, prot
func getAllContainers(ctx context.Context, t testing.TB, client client.ContainerAPIClient) []types.Container { func getAllContainers(ctx context.Context, t testing.TB, client client.ContainerAPIClient) []types.Container {
t.Helper() t.Helper()
containers, err := client.ContainerList(ctx, types.ContainerListOptions{ containers, err := client.ContainerList(ctx, types.ContainerListOptions{
Quiet: true, All: true,
All: true,
}) })
assert.Check(t, err, "failed to list containers") assert.Check(t, err, "failed to list containers")
return containers return containers