From 4f43cb660a905983252c2162e7ca694dd3a415f1 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 19 Oct 2022 13:22:14 +0200 Subject: [PATCH] skip TestImagePullStoredfDigestForOtherRepo() on Windows and rootless - On Windows, we don't build and run a local test registry (we're not running docker-in-docker), so we need to skip this test. - On rootless, networking doesn't support this (currently) Signed-off-by: Sebastiaan van Stijn --- integration/image/pull_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/integration/image/pull_test.go b/integration/image/pull_test.go index 940a21e1ff..bf63045a61 100644 --- a/integration/image/pull_test.go +++ b/integration/image/pull_test.go @@ -117,6 +117,9 @@ func createTestImage(ctx context.Context, t testing.TB, store content.Store) ima // Make sure that pulling by an already cached digest but for a different ref (that should not have that digest) // verifies with the remote that the digest exists in that repo. func TestImagePullStoredfDigestForOtherRepo(t *testing.T) { + skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon") + skip.If(t, testEnv.OSType == "windows", "We don't run a test registry on Windows") + skip.If(t, testEnv.IsRootless, "Rootless has a different view of localhost (needed for test registry access)") defer setupTest(t)() reg := registry.NewV2(t, registry.WithStdout(os.Stdout), registry.WithStderr(os.Stderr))