kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #28721 from dongluochen/attachable_network

Browse source 
Fix network attachable option
This commit is contained in:
Madhu Venugopal 2016-11-29 11:04:49 -08:00 • committed by GitHub
commit 4fae94f663
4 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/server/router/network/network_routes.go
View file

@ -172,10 +172,10 @@ func (n *networkRouter) buildNetworkResource(nw libnetwork.Network) *types.Netwo
r.Driver = nw.Type() r.Driver = nw.Type()
r.EnableIPv6 = info.IPv6Enabled() r.EnableIPv6 = info.IPv6Enabled()
r.Internal = info.Internal() r.Internal = info.Internal()
r.Attachable = info.Attachable()
r.Options = info.DriverOptions() r.Options = info.DriverOptions()
r.Containers = make(map[string]types.EndpointResource) r.Containers = make(map[string]types.EndpointResource)
buildIpamResources(r, info) buildIpamResources(r, info)
r.Internal = info.Internal()
r.Labels = info.Labels() r.Labels = info.Labels()
peers := info.Peers() peers := info.Peers()

1
daemon/cluster/executor/container/container.go
View file

@ -571,6 +571,7 @@ func (c *containerConfig) networkCreateRequest(name string) (clustertypes.Networ
Options: na.Network.DriverState.Options, Options: na.Network.DriverState.Options,
Labels: na.Network.Spec.Annotations.Labels, Labels: na.Network.Spec.Annotations.Labels,
Internal: na.Network.Spec.Internal, Internal: na.Network.Spec.Internal,
Attachable: na.Network.Spec.Attachable,
EnableIPv6: na.Network.Spec.Ipv6Enabled, EnableIPv6: na.Network.Spec.Ipv6Enabled,
CheckDuplicate: true, CheckDuplicate: true,
} }

1
daemon/network.go
View file

@ -269,6 +269,7 @@ func (daemon *Daemon) createNetwork(create types.NetworkCreateRequest, id string
libnetwork.NetworkOptionEnableIPv6(create.EnableIPv6), libnetwork.NetworkOptionEnableIPv6(create.EnableIPv6),
libnetwork.NetworkOptionDriverOpts(create.Options), libnetwork.NetworkOptionDriverOpts(create.Options),
libnetwork.NetworkOptionLabels(create.Labels), libnetwork.NetworkOptionLabels(create.Labels),
libnetwork.NetworkOptionAttachable(create.Attachable),
} }
if create.IPAM != nil { if create.IPAM != nil {

28
integration-cli/docker_cli_swarm_test.go
View file

@ -425,6 +425,34 @@ func (s *DockerSwarmSuite) TestSwarmContainerAttachByNetworkId(c *check.C) {
waitAndAssert(c, 3*time.Second, checkNetwork, checker.Not(checker.Contains), "testnet") waitAndAssert(c, 3*time.Second, checkNetwork, checker.Not(checker.Contains), "testnet")
} }
func (s *DockerSwarmSuite) TestOverlayAttachable(c *check.C) {
d1 := s.AddDaemon(c, true, true)
d2 := s.AddDaemon(c, true, false)
out, err := d1.Cmd("network", "create", "-d", "overlay", "--attachable", "ovnet")
c.Assert(err, checker.IsNil, check.Commentf(out))
// validate attachable
out, err = d1.Cmd("network", "inspect", "--format", "{{json .Attachable}}", "ovnet")
c.Assert(err, checker.IsNil, check.Commentf(out))
c.Assert(strings.TrimSpace(out), checker.Equals, "true")
// validate containers can attache to this overlay network
out, err = d1.Cmd("run", "-d", "--network", "ovnet", "--name", "c1", "busybox", "top")
c.Assert(err, checker.IsNil, check.Commentf(out))
out, err = d2.Cmd("run", "-d", "--network", "ovnet", "--name", "c2", "busybox", "top")
c.Assert(err, checker.IsNil, check.Commentf(out))
// redo validation, there was a bug that the value of attachable changes after
// containers attach to the network
out, err = d1.Cmd("network", "inspect", "--format", "{{json .Attachable}}", "ovnet")
c.Assert(err, checker.IsNil, check.Commentf(out))
c.Assert(strings.TrimSpace(out), checker.Equals, "true")
out, err = d2.Cmd("network", "inspect", "--format", "{{json .Attachable}}", "ovnet")
c.Assert(err, checker.IsNil, check.Commentf(out))
c.Assert(strings.TrimSpace(out), checker.Equals, "true")
}
func (s *DockerSwarmSuite) TestSwarmRemoveInternalNetwork(c *check.C) { func (s *DockerSwarmSuite) TestSwarmRemoveInternalNetwork(c *check.C) {
d := s.AddDaemon(c, true, true) d := s.AddDaemon(c, true, true)