From 50bee2f8114ce562d63b08665f7371aa5a568b2c Mon Sep 17 00:00:00 2001 From: "Guillaume J. Charmes" Date: Mon, 25 Mar 2013 18:43:25 -0700 Subject: [PATCH] Fix termcaps on the linux client --- container.go | 3 +++ term/termios_linux.go | 62 ++++++++++++++++++++++++++++++++----------- 2 files changed, 49 insertions(+), 16 deletions(-) diff --git a/container.go b/container.go index 7e7077c123..7693f85a98 100644 --- a/container.go +++ b/container.go @@ -255,6 +255,9 @@ func (container *Container) Start() error { var err error if container.Config.Tty { + container.cmd.Env = append(container.Config.Env, + "TERM="+os.Getenv("TERM"), + ) err = container.startPty() } else { err = container.start() diff --git a/term/termios_linux.go b/term/termios_linux.go index 933ef84c4d..f018a58e63 100644 --- a/term/termios_linux.go +++ b/term/termios_linux.go @@ -1,10 +1,31 @@ package term import ( - "syscall" - "unsafe" + "os" + "syscall" + "unsafe" ) +// #include +// #include +/* +void MakeRaw() { + struct termios t; + + // FIXME: Handle errors? + ioctl(0, TCGETS, &t); + + t.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON); + t.c_oflag &= ~OPOST; + t.c_lflag &= ~(ECHO | ECHONL | ICANON | ISIG | IEXTEN); + t.c_cflag &= ~(CSIZE | PARENB); + t.c_cflag |= CS8; + + ioctl(0, TCSETS, &t); +} +*/ +import "C" + const ( getTermios = syscall.TCGETS setTermios = syscall.TCSETS @@ -14,19 +35,28 @@ const ( // mode and returns the previous state of the terminal so that it can be // restored. func MakeRaw(fd int) (*State, error) { - var oldState State - if _, _, err := syscall.Syscall6(syscall.SYS_IOCTL, uintptr(fd), uintptr(getTermios), uintptr(unsafe.Pointer(&oldState.termios)), 0, 0, 0); err != 0 { - return nil, err - } - newState := oldState.termios - newState.Iflag &^= ISTRIP | IXON | IXOFF - newState.Iflag |= ICRNL - newState.Oflag |= ONLCR - newState.Lflag &^= ECHO | ICANON | ISIG - if _, _, err := syscall.Syscall6(syscall.SYS_IOCTL, uintptr(fd), uintptr(setTermios), uintptr(unsafe.Pointer(&newState)), 0, 0, 0); err != 0 { - return nil, err - } + fd = int(os.Stdin.Fd()) - return &oldState, nil -} \ No newline at end of file + var oldState State + if _, _, err := syscall.Syscall6(syscall.SYS_IOCTL, uintptr(fd), syscall.TCGETS, uintptr(unsafe.Pointer(&oldState.termios)), 0, 0, 0); err != 0 { + return nil, err + } + C.MakeRaw() + return &oldState, nil + + // FIXME: post on goland issues this: very same as the C function bug non-working + + // newState := oldState.termios + + // newState.Iflag &^= (IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON) + // newState.Oflag &^= OPOST + // newState.Lflag &^= (ECHO | syscall.ECHONL | ICANON | ISIG | IEXTEN) + // newState.Cflag &^= (CSIZE | syscall.PARENB) + // newState.Cflag |= CS8 + + // if _, _, err := syscall.Syscall(syscall.SYS_IOCTL, uintptr(fd), syscall.TCSETS, uintptr(unsafe.Pointer(&newState))); err != 0 { + // return nil, err + // } + // return &oldState, nil +}