Merge pull request #35138 from vdemeester/foo

Carry 35078 : Fix TestErrorCases to run all tests
2017-10-09 12:16:16 -07:00 · 2017-10-09 12:16:16 -07:00 · 513f0e6c26
parent d9cd40d58b d2c41f06c3
commit 513f0e6c26
1 changed files with 1 additions and 5 deletions
--- a/builder/dockerfile/instructions/parse_test.go
+++ b/builder/dockerfile/instructions/parse_test.go
@ -194,11 +194,7 @@ func TestErrorCases(t *testing.T) {
 		}
 		n := ast.AST.Children[0]
 		_, err = ParseInstruction(n)
-		if err != nil {
-			testutil.ErrorContains(t, err, c.expectedError)
-			return
-		}
-		t.Fatalf("No error when executing test %s", c.name)
+		testutil.ErrorContains(t, err, c.expectedError)
 	}

 }