mirror of
				https://github.com/moby/moby.git
				synced 2022-11-09 12:21:53 -05:00 
			
		
		
		
	Merge pull request #23400 from runcom/fix-digest-test
integration-cli: use distribution/reference.DigestRegexp
This commit is contained in:
		
						commit
						51f0def774
					
				
					 1 changed files with 6 additions and 6 deletions
				
			
		| 
						 | 
				
			
			@ -12,7 +12,7 @@ import (
 | 
			
		|||
	"strings"
 | 
			
		||||
	"time"
 | 
			
		||||
 | 
			
		||||
	"github.com/docker/distribution/digest"
 | 
			
		||||
	"github.com/docker/distribution/reference"
 | 
			
		||||
	"github.com/docker/docker/cliconfig"
 | 
			
		||||
	"github.com/docker/docker/pkg/integration/checker"
 | 
			
		||||
	"github.com/go-check/check"
 | 
			
		||||
| 
						 | 
				
			
			@ -215,7 +215,7 @@ func (s *DockerRegistrySuite) TestCrossRepositoryLayerPush(c *check.C) {
 | 
			
		|||
	// ensure that none of the layers were mounted from another repository during push
 | 
			
		||||
	c.Assert(strings.Contains(out1, "Mounted from"), check.Equals, false)
 | 
			
		||||
 | 
			
		||||
	digest1 := digest.DigestRegexp.FindString(out1)
 | 
			
		||||
	digest1 := reference.DigestRegexp.FindString(out1)
 | 
			
		||||
	c.Assert(len(digest1), checker.GreaterThan, 0, check.Commentf("no digest found for pushed manifest"))
 | 
			
		||||
 | 
			
		||||
	destRepoName := fmt.Sprintf("%v/dockercli/crossrepopush", privateRegistryURL)
 | 
			
		||||
| 
						 | 
				
			
			@ -227,7 +227,7 @@ func (s *DockerRegistrySuite) TestCrossRepositoryLayerPush(c *check.C) {
 | 
			
		|||
	// ensure that layers were mounted from the first repo during push
 | 
			
		||||
	c.Assert(strings.Contains(out2, "Mounted from dockercli/busybox"), check.Equals, true)
 | 
			
		||||
 | 
			
		||||
	digest2 := digest.DigestRegexp.FindString(out2)
 | 
			
		||||
	digest2 := reference.DigestRegexp.FindString(out2)
 | 
			
		||||
	c.Assert(len(digest2), checker.GreaterThan, 0, check.Commentf("no digest found for pushed manifest"))
 | 
			
		||||
	c.Assert(digest1, check.Equals, digest2)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -248,7 +248,7 @@ func (s *DockerSchema1RegistrySuite) TestCrossRepositoryLayerPushNotSupported(c
 | 
			
		|||
	// ensure that none of the layers were mounted from another repository during push
 | 
			
		||||
	c.Assert(strings.Contains(out1, "Mounted from"), check.Equals, false)
 | 
			
		||||
 | 
			
		||||
	digest1 := digest.DigestRegexp.FindString(out1)
 | 
			
		||||
	digest1 := reference.DigestRegexp.FindString(out1)
 | 
			
		||||
	c.Assert(len(digest1), checker.GreaterThan, 0, check.Commentf("no digest found for pushed manifest"))
 | 
			
		||||
 | 
			
		||||
	destRepoName := fmt.Sprintf("%v/dockercli/crossrepopush", privateRegistryURL)
 | 
			
		||||
| 
						 | 
				
			
			@ -260,9 +260,9 @@ func (s *DockerSchema1RegistrySuite) TestCrossRepositoryLayerPushNotSupported(c
 | 
			
		|||
	// schema1 registry should not support cross-repo layer mounts, so ensure that this does not happen
 | 
			
		||||
	c.Assert(strings.Contains(out2, "Mounted from"), check.Equals, false)
 | 
			
		||||
 | 
			
		||||
	digest2 := digest.DigestRegexp.FindString(out2)
 | 
			
		||||
	digest2 := reference.DigestRegexp.FindString(out2)
 | 
			
		||||
	c.Assert(len(digest2), checker.GreaterThan, 0, check.Commentf("no digest found for pushed manifest"))
 | 
			
		||||
	c.Assert(digest1, check.Equals, digest2)
 | 
			
		||||
	c.Assert(digest1, check.Not(check.Equals), digest2)
 | 
			
		||||
 | 
			
		||||
	// ensure that we can pull and run the second pushed repository
 | 
			
		||||
	dockerCmd(c, "rmi", destRepoName)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue