From 5239aa1f11c32f3befc25fb2fa8a0ecf75ec4bf6 Mon Sep 17 00:00:00 2001 From: Michael Crosby Date: Tue, 11 Mar 2014 10:40:06 -0700 Subject: [PATCH] Move server and buildfile into server pkg Docker-DCO-1.1-Signed-off-by: Michael Crosby (github: crosbymichael) --- builtins/builtins.go | 4 +-- buildfile.go => server/buildfile.go | 30 +------------------ server.go => server/server.go | 6 ++-- .../server_unit_test.go | 2 +- utils/streamformatter.go | 29 ++++++++++++++++++ 5 files changed, 36 insertions(+), 35 deletions(-) rename buildfile.go => server/buildfile.go (96%) rename server.go => server/server.go (99%) rename server_unit_test.go => server/server_unit_test.go (99%) diff --git a/builtins/builtins.go b/builtins/builtins.go index ba3f41b1ca..eb4a0be874 100644 --- a/builtins/builtins.go +++ b/builtins/builtins.go @@ -3,9 +3,9 @@ package builtins import ( "github.com/dotcloud/docker/engine" - "github.com/dotcloud/docker" "github.com/dotcloud/docker/api" "github.com/dotcloud/docker/networkdriver/lxc" + "github.com/dotcloud/docker/server" ) func Register(eng *engine.Engine) { @@ -34,6 +34,6 @@ func remote(eng *engine.Engine) { // These components should be broken off into plugins of their own. // func daemon(eng *engine.Engine) { - eng.Register("initserver", docker.InitServer) + eng.Register("initserver", server.InitServer) eng.Register("init_networkdriver", lxc.InitDriver) } diff --git a/buildfile.go b/server/buildfile.go similarity index 96% rename from buildfile.go rename to server/buildfile.go index da72be60fb..af6702cc1d 100644 --- a/buildfile.go +++ b/server/buildfile.go @@ -1,4 +1,4 @@ -package docker +package server import ( "crypto/sha256" @@ -591,34 +591,6 @@ func (b *buildFile) CmdAdd(args string) error { return nil } -type StdoutFormater struct { - io.Writer - *utils.StreamFormatter -} - -func (sf *StdoutFormater) Write(buf []byte) (int, error) { - formattedBuf := sf.StreamFormatter.FormatStream(string(buf)) - n, err := sf.Writer.Write(formattedBuf) - if n != len(formattedBuf) { - return n, io.ErrShortWrite - } - return len(buf), err -} - -type StderrFormater struct { - io.Writer - *utils.StreamFormatter -} - -func (sf *StderrFormater) Write(buf []byte) (int, error) { - formattedBuf := sf.StreamFormatter.FormatStream("\033[91m" + string(buf) + "\033[0m") - n, err := sf.Writer.Write(formattedBuf) - if n != len(formattedBuf) { - return n, io.ErrShortWrite - } - return len(buf), err -} - func (b *buildFile) create() (*runtime.Container, error) { if b.image == "" { return nil, fmt.Errorf("Please provide a source image with `from` prior to run") diff --git a/server.go b/server/server.go similarity index 99% rename from server.go rename to server/server.go index 75fa633e8f..eb9a3a396b 100644 --- a/server.go +++ b/server/server.go @@ -1,4 +1,4 @@ -package docker +package server import ( "encoding/json" @@ -456,11 +456,11 @@ func (srv *Server) Build(job *engine.Job) engine.Status { sf := utils.NewStreamFormatter(job.GetenvBool("json")) b := NewBuildFile(srv, - &StdoutFormater{ + &utils.StdoutFormater{ Writer: job.Stdout, StreamFormatter: sf, }, - &StderrFormater{ + &utils.StderrFormater{ Writer: job.Stdout, StreamFormatter: sf, }, diff --git a/server_unit_test.go b/server/server_unit_test.go similarity index 99% rename from server_unit_test.go rename to server/server_unit_test.go index 6a90ca5892..b471c5c581 100644 --- a/server_unit_test.go +++ b/server/server_unit_test.go @@ -1,4 +1,4 @@ -package docker +package server import ( "github.com/dotcloud/docker/utils" diff --git a/utils/streamformatter.go b/utils/streamformatter.go index 8876fa5cb7..d2758d3ca6 100644 --- a/utils/streamformatter.go +++ b/utils/streamformatter.go @@ -3,6 +3,7 @@ package utils import ( "encoding/json" "fmt" + "io" ) type StreamFormatter struct { @@ -90,3 +91,31 @@ func (sf *StreamFormatter) Used() bool { func (sf *StreamFormatter) Json() bool { return sf.json } + +type StdoutFormater struct { + io.Writer + *StreamFormatter +} + +func (sf *StdoutFormater) Write(buf []byte) (int, error) { + formattedBuf := sf.StreamFormatter.FormatStream(string(buf)) + n, err := sf.Writer.Write(formattedBuf) + if n != len(formattedBuf) { + return n, io.ErrShortWrite + } + return len(buf), err +} + +type StderrFormater struct { + io.Writer + *StreamFormatter +} + +func (sf *StderrFormater) Write(buf []byte) (int, error) { + formattedBuf := sf.StreamFormatter.FormatStream("\033[91m" + string(buf) + "\033[0m") + n, err := sf.Writer.Write(formattedBuf) + if n != len(formattedBuf) { + return n, io.ErrShortWrite + } + return len(buf), err +}