1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00

Merge pull request #7354 from timthelion/patch-8

Remove the restriction on multi-user PRs
This commit is contained in:
Michael Crosby 2014-07-31 16:19:10 -07:00
commit 5395cecc48

View file

@ -120,8 +120,6 @@ committing your changes. Most editors have plug-ins that do this automatically.
Pull requests descriptions should be as clear as possible and include a Pull requests descriptions should be as clear as possible and include a
reference to all the issues that they address. reference to all the issues that they address.
Pull requests must not contain commits from other users or branches.
Commit messages must start with a capitalized and short summary (max. 50 Commit messages must start with a capitalized and short summary (max. 50
chars) written in the imperative, followed by an optional, more detailed chars) written in the imperative, followed by an optional, more detailed
explanatory text which is separated from the summary by an empty line. explanatory text which is separated from the summary by an empty line.
@ -132,6 +130,12 @@ sure to post a comment after pushing. The new commits will show up in the pull
request automatically, but the reviewers will not be notified unless you request automatically, but the reviewers will not be notified unless you
comment. comment.
Pull requests must be cleanly rebased ontop of master without multiple branches
mixed into the PR.
**Git tip**: If your PR no longer merges cleanly, use `rebase master` in your
feature branch to update your pull request rather than `merge master`.
Before the pull request is merged, make sure that you squash your commits into Before the pull request is merged, make sure that you squash your commits into
logical units of work using `git rebase -i` and `git push -f`. After every logical units of work using `git rebase -i` and `git push -f`. After every
commit the test suite should be passing. Include documentation changes in the commit the test suite should be passing. Include documentation changes in the