From bc5768733db79874d8918e8499df01d68cae2d6e Mon Sep 17 00:00:00 2001 From: Zhang Wei Date: Sat, 17 Sep 2016 19:40:58 +0800 Subject: [PATCH] Fix flaky unit test Fix flaky test `TestHTTPTimeout` caused by precision problem. Signed-off-by: Zhang Wei --- pkg/plugins/client_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/plugins/client_test.go b/pkg/plugins/client_test.go index be71a371da..6551d53697 100644 --- a/pkg/plugins/client_test.go +++ b/pkg/plugins/client_test.go @@ -47,14 +47,14 @@ func testHTTPTimeout(t *testing.T, timeout, epsilon time.Duration) { t.Fatalf("The request should be canceled %v", err) } elapsed := time.Now().Sub(begin) - if elapsed < timeout || elapsed > timeout+epsilon { + if elapsed < timeout-epsilon || elapsed > timeout+epsilon { t.Fatalf("elapsed time: got %v, expected %v (epsilon=%v)", elapsed, timeout, epsilon) } } func TestHTTPTimeout(t *testing.T) { - testHTTPTimeout(t, 5*time.Second, 1*time.Second) + testHTTPTimeout(t, 5*time.Second, 500*time.Millisecond) } func TestFailedConnection(t *testing.T) {