From 596e91638cbe8b583dff4fdfc5a52e9d3840b20f Mon Sep 17 00:00:00 2001 From: Arnaud Porterie Date: Wed, 6 May 2015 14:35:10 -0700 Subject: [PATCH] Remove unused Dockerfile instruction INSERT Signed-off-by: Arnaud Porterie --- builder/command/command.go | 2 -- builder/dispatchers.go | 5 ----- builder/evaluator.go | 1 - builder/parser/parser.go | 1 - 4 files changed, 9 deletions(-) diff --git a/builder/command/command.go b/builder/command/command.go index 16544f0267..8e5d980321 100644 --- a/builder/command/command.go +++ b/builder/command/command.go @@ -16,7 +16,6 @@ const ( Expose = "expose" Volume = "volume" User = "user" - Insert = "insert" ) // Commands is list of all Dockerfile commands @@ -35,5 +34,4 @@ var Commands = map[string]struct{}{ Expose: {}, Volume: {}, User: {}, - Insert: {}, } diff --git a/builder/dispatchers.go b/builder/dispatchers.go index 7d1dab6407..4d4c123963 100644 --- a/builder/dispatchers.go +++ b/builder/dispatchers.go @@ -512,8 +512,3 @@ func volume(b *Builder, args []string, attributes map[string]bool, original stri } return nil } - -// INSERT is no longer accepted, but we still parse it. -func insert(b *Builder, args []string, attributes map[string]bool, original string) error { - return fmt.Errorf("INSERT has been deprecated. Please use ADD instead") -} diff --git a/builder/evaluator.go b/builder/evaluator.go index bdcc6b29a8..49e4a76481 100644 --- a/builder/evaluator.go +++ b/builder/evaluator.go @@ -71,7 +71,6 @@ func init() { command.Expose: expose, command.Volume: volume, command.User: user, - command.Insert: insert, } } diff --git a/builder/parser/parser.go b/builder/parser/parser.go index f68c710c06..2260cd5270 100644 --- a/builder/parser/parser.go +++ b/builder/parser/parser.go @@ -61,7 +61,6 @@ func init() { command.Entrypoint: parseMaybeJSON, command.Expose: parseStringsWhitespaceDelimited, command.Volume: parseMaybeJSONToList, - command.Insert: parseIgnore, } }