diff --git a/api/client/build.go b/api/client/build.go index b700884835..7d226ee803 100644 --- a/api/client/build.go +++ b/api/client/build.go @@ -27,9 +27,9 @@ import ( flag "github.com/docker/docker/pkg/mflag" "github.com/docker/docker/pkg/progress" "github.com/docker/docker/pkg/streamformatter" - "github.com/docker/docker/pkg/ulimit" "github.com/docker/docker/pkg/urlutil" "github.com/docker/docker/reference" + runconfigopts "github.com/docker/docker/runconfig/opts" "github.com/docker/docker/utils" "github.com/docker/go-units" ) @@ -62,8 +62,8 @@ func (cli *DockerCli) CmdBuild(args ...string) error { cmd.Var(&flBuildArg, []string{"-build-arg"}, "Set build-time variables") isolation := cmd.String([]string{"-isolation"}, "", "Container isolation level") - ulimits := make(map[string]*ulimit.Ulimit) - flUlimits := opts.NewUlimitOpt(&ulimits) + ulimits := make(map[string]*units.Ulimit) + flUlimits := runconfigopts.NewUlimitOpt(&ulimits) cmd.Var(flUlimits, []string{"-ulimit"}, "Ulimit options") cmd.Require(flag.Exact, 1) diff --git a/daemon/config_unix.go b/daemon/config_unix.go index 8772aad977..06439ef50b 100644 --- a/daemon/config_unix.go +++ b/daemon/config_unix.go @@ -7,7 +7,8 @@ import ( "github.com/docker/docker/opts" flag "github.com/docker/docker/pkg/mflag" - "github.com/docker/docker/pkg/ulimit" + runconfigopts "github.com/docker/docker/runconfig/opts" + "github.com/docker/go-units" ) var ( @@ -27,7 +28,7 @@ type Config struct { EnableSelinuxSupport bool RemappedRoot string SocketGroup string - Ulimits map[string]*ulimit.Ulimit + Ulimits map[string]*units.Ulimit } // bridgeConfig stores all the bridge driver specific @@ -59,8 +60,8 @@ func (config *Config) InstallFlags(cmd *flag.FlagSet, usageFn func(string) strin // Then platform-specific install flags cmd.BoolVar(&config.EnableSelinuxSupport, []string{"-selinux-enabled"}, false, usageFn("Enable selinux support")) cmd.StringVar(&config.SocketGroup, []string{"G", "-group"}, "docker", usageFn("Group for the unix socket")) - config.Ulimits = make(map[string]*ulimit.Ulimit) - cmd.Var(opts.NewUlimitOpt(&config.Ulimits), []string{"-default-ulimit"}, usageFn("Set default ulimits for containers")) + config.Ulimits = make(map[string]*units.Ulimit) + cmd.Var(runconfigopts.NewUlimitOpt(&config.Ulimits), []string{"-default-ulimit"}, usageFn("Set default ulimits for containers")) cmd.BoolVar(&config.Bridge.EnableIPTables, []string{"#iptables", "-iptables"}, true, usageFn("Enable addition of iptables rules")) cmd.BoolVar(&config.Bridge.EnableIPForward, []string{"#ip-forward", "-ip-forward"}, true, usageFn("Enable net.ipv4.ip_forward")) cmd.BoolVar(&config.Bridge.EnableIPMasq, []string{"-ip-masq"}, true, usageFn("Enable IP masquerading")) diff --git a/opts/ulimit.go b/runconfig/opts/ulimit.go similarity index 71% rename from opts/ulimit.go rename to runconfig/opts/ulimit.go index b41f475bd5..0aec91f170 100644 --- a/opts/ulimit.go +++ b/runconfig/opts/ulimit.go @@ -3,25 +3,25 @@ package opts import ( "fmt" - "github.com/docker/docker/pkg/ulimit" + "github.com/docker/go-units" ) // UlimitOpt defines a map of Ulimits type UlimitOpt struct { - values *map[string]*ulimit.Ulimit + values *map[string]*units.Ulimit } // NewUlimitOpt creates a new UlimitOpt -func NewUlimitOpt(ref *map[string]*ulimit.Ulimit) *UlimitOpt { +func NewUlimitOpt(ref *map[string]*units.Ulimit) *UlimitOpt { if ref == nil { - ref = &map[string]*ulimit.Ulimit{} + ref = &map[string]*units.Ulimit{} } return &UlimitOpt{ref} } // Set validates a Ulimit and sets its name as a key in UlimitOpt func (o *UlimitOpt) Set(val string) error { - l, err := ulimit.Parse(val) + l, err := units.ParseUlimit(val) if err != nil { return err } @@ -42,8 +42,8 @@ func (o *UlimitOpt) String() string { } // GetList returns a slice of pointers to Ulimits. -func (o *UlimitOpt) GetList() []*ulimit.Ulimit { - var ulimits []*ulimit.Ulimit +func (o *UlimitOpt) GetList() []*units.Ulimit { + var ulimits []*units.Ulimit for _, v := range *o.values { ulimits = append(ulimits, v) } diff --git a/opts/ulimit_test.go b/runconfig/opts/ulimit_test.go similarity index 92% rename from opts/ulimit_test.go rename to runconfig/opts/ulimit_test.go index 3845d1ec18..0aa3facdfb 100644 --- a/opts/ulimit_test.go +++ b/runconfig/opts/ulimit_test.go @@ -3,11 +3,11 @@ package opts import ( "testing" - "github.com/docker/docker/pkg/ulimit" + "github.com/docker/go-units" ) func TestUlimitOpt(t *testing.T) { - ulimitMap := map[string]*ulimit.Ulimit{ + ulimitMap := map[string]*units.Ulimit{ "nofile": {"nofile", 1024, 512}, } diff --git a/runconfig/parse.go b/runconfig/parse.go index 488af26127..3556202f4d 100644 --- a/runconfig/parse.go +++ b/runconfig/parse.go @@ -12,6 +12,7 @@ import ( flag "github.com/docker/docker/pkg/mflag" "github.com/docker/docker/pkg/mount" "github.com/docker/docker/pkg/signal" + runconfigopts "github.com/docker/docker/runconfig/opts" "github.com/docker/docker/volume" "github.com/docker/go-connections/nat" "github.com/docker/go-units" @@ -63,7 +64,7 @@ func Parse(cmd *flag.FlagSet, args []string) (*container.Config, *container.Host flLabels = opts.NewListOpts(opts.ValidateEnv) flDevices = opts.NewListOpts(ValidateDevice) - flUlimits = opts.NewUlimitOpt(nil) + flUlimits = runconfigopts.NewUlimitOpt(nil) flPublish = opts.NewListOpts(nil) flExpose = opts.NewListOpts(nil)