kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Match case for variables in sysinfo pkg

Browse source 
I noticied an inconsistency when reviewing docker/pull/20692.

Changing Ip to IP and Nf to NF.

More info: The golang folks recommend that you keep the initials consistent:
https://github.com/golang/go/wiki/CodeReviewComments#initialisms.

Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
This commit is contained in:
Christy Perez 2016-02-26 12:47:43 -06:00
parent 29ce086e38
commit 5b3fc7aab2
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
daemon/info.go
View file

@ -75,8 +75,8 @@ func (daemon *Daemon) SystemInfo() (*types.Info, error) {
DriverStatus: daemon.layerStore.DriverStatus(), DriverStatus: daemon.layerStore.DriverStatus(),
Plugins: daemon.showPluginsInfo(), Plugins: daemon.showPluginsInfo(),
IPv4Forwarding: !sysInfo.IPv4ForwardingDisabled, IPv4Forwarding: !sysInfo.IPv4ForwardingDisabled,
BridgeNfIptables: !sysInfo.BridgeNfCallIptablesDisabled, BridgeNfIptables: !sysInfo.BridgeNFCallIPTablesDisabled,
BridgeNfIP6tables: !sysInfo.BridgeNfCallIP6tablesDisabled, BridgeNfIP6tables: !sysInfo.BridgeNFCallIP6TablesDisabled,
Debug: utils.IsDebugEnabled(), Debug: utils.IsDebugEnabled(),
NFd: fileutils.GetTotalUsedFds(), NFd: fileutils.GetTotalUsedFds(),
NGoroutines: runtime.NumGoroutine(), NGoroutines: runtime.NumGoroutine(),

4
integration-cli/requirements_unix.go
View file

@ -83,13 +83,13 @@ var (
} }
bridgeNfIptables = testRequirement{ bridgeNfIptables = testRequirement{
func() bool { func() bool {
return !SysInfo.BridgeNfCallIptablesDisabled return !SysInfo.BridgeNFCallIPTablesDisabled
}, },
"Test requires that bridge-nf-call-iptables support be enabled in the daemon.", "Test requires that bridge-nf-call-iptables support be enabled in the daemon.",
} }
bridgeNfIP6tables = testRequirement{ bridgeNfIP6tables = testRequirement{
func() bool { func() bool {
return !SysInfo.BridgeNfCallIP6tablesDisabled return !SysInfo.BridgeNFCallIP6TablesDisabled
}, },
"Test requires that bridge-nf-call-ip6tables support be enabled in the daemon.", "Test requires that bridge-nf-call-ip6tables support be enabled in the daemon.",
} }

4
pkg/sysinfo/sysinfo.go
View file

@ -19,10 +19,10 @@ type SysInfo struct {
IPv4ForwardingDisabled bool IPv4ForwardingDisabled bool
// Whether bridge-nf-call-iptables is supported or not // Whether bridge-nf-call-iptables is supported or not
BridgeNfCallIptablesDisabled bool BridgeNFCallIPTablesDisabled bool
// Whether bridge-nf-call-ip6tables is supported or not // Whether bridge-nf-call-ip6tables is supported or not
BridgeNfCallIP6tablesDisabled bool BridgeNFCallIP6TablesDisabled bool
// Whether the cgroup has the mountpoint of "devices" or not // Whether the cgroup has the mountpoint of "devices" or not
CgroupDevicesEnabled bool CgroupDevicesEnabled bool

4
pkg/sysinfo/sysinfo_linux.go
View file

@ -50,8 +50,8 @@ func New(quiet bool) *SysInfo {
sysInfo.CgroupDevicesEnabled = ok sysInfo.CgroupDevicesEnabled = ok
sysInfo.IPv4ForwardingDisabled = !readProcBool("/proc/sys/net/ipv4/ip_forward") sysInfo.IPv4ForwardingDisabled = !readProcBool("/proc/sys/net/ipv4/ip_forward")
sysInfo.BridgeNfCallIptablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-iptables") sysInfo.BridgeNFCallIPTablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-iptables")
sysInfo.BridgeNfCallIP6tablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-ip6tables") sysInfo.BridgeNFCallIP6TablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-ip6tables")
// Check if AppArmor is supported. // Check if AppArmor is supported.
if _, err := os.Stat("/sys/kernel/security/apparmor"); !os.IsNotExist(err) { if _, err := os.Stat("/sys/kernel/security/apparmor"); !os.IsNotExist(err) {