kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #33695 from cpuguy83/volumes_check_ownership

Browse source 
Don't chown/chmod volumes if not needed.
This commit is contained in:
Brian Goff 2017-06-19 06:31:58 -07:00 • committed by GitHub
commit 630b9a45d2
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
container/container_unix.go
View file

@ -441,11 +441,26 @@ func copyOwnership(source, destination string) error {
return err
}
if err := os.Chown(destination, int(stat.UID()), int(stat.GID())); err != nil {
destStat, err := system.Stat(destination)
if err != nil {
return err
}
return os.Chmod(destination, os.FileMode(stat.Mode()))
// In some cases, even though UID/GID match and it would effectively be a no-op,
// this can return a permission denied error... for example if this is an NFS
// mount.
// Since it's not really an error that we can't chown to the same UID/GID, don't
// even bother trying in such cases.
if stat.UID() != destStat.UID() || stat.GID() != destStat.GID() {
if err := os.Chown(destination, int(stat.UID()), int(stat.GID())); err != nil {
return err
}
}
if stat.Mode() != destStat.Mode() {
return os.Chmod(destination, os.FileMode(stat.Mode()))
}
return nil
}
// TmpfsMounts returns the list of tmpfs mounts