kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Re-enabled cat, write and ls ; Added creation date to image metadata

Browse source
This commit is contained in:
shin- 2013-03-12 04:24:26 -07:00
parent 5d6199b925
commit 63dd8f1018
3 changed files with 95 additions and 84 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
fs/changes.go
View file

@ -125,20 +125,3 @@ func (mp *Mountpoint) Reset() error {
} }
return nil return nil
} }
// Open opens the named file for reading.
// func (fs *Filesystem) OpenFile(path string, flag int, perm os.FileMode) (*os.File, error) {
// if err := fs.EnsureMounted(); err != nil {
// return nil, err
// }
// return os.OpenFile(filepath.Join(fs.RootFS, path), flag, perm)
// }
// ReadDir reads the directory named by dirname, relative to the Filesystem's root,
// and returns a list of sorted directory entries
// func (fs *Filesystem) ReadDir(dirname string) ([]os.FileInfo, error) {
// if err := fs.EnsureMounted(); err != nil {
// return nil, err
// }
// return ioutil.ReadDir(filepath.Join(fs.RootFS, dirname))
// }

20
fs/store.go
View file

@ -8,6 +8,7 @@ import (
_ "github.com/mattn/go-sqlite3" _ "github.com/mattn/go-sqlite3"
"github.com/shykes/gorp" //Forked to implement CreateTablesOpts "github.com/shykes/gorp" //Forked to implement CreateTablesOpts
"io" "io"
"io/ioutil"
"os" "os"
"path" "path"
"path/filepath" "path/filepath"
@ -115,6 +116,7 @@ func (store *Store) Create(layerData Archive, parent *Image, pth, comment string
img := &Image{ img := &Image{
Id: future.RandomId(), Id: future.RandomId(),
Comment: comment, Comment: comment,
Created: time.Now().Unix(),
store: store, store: store,
} }
// FIXME: we shouldn't have to pass os.Stderr to AddLayer()... // FIXME: we shouldn't have to pass os.Stderr to AddLayer()...
@ -163,6 +165,7 @@ type Image struct {
Id string Id string
Parent string Parent string
Comment string Comment string
Created int64
store *Store `db:"-"` store *Store `db:"-"`
} }
@ -356,6 +359,23 @@ func (store *Store) FetchMountpoint(root, rw string) (*Mountpoint, error) {
return mp, nil return mp, nil
} }
// OpenFile opens the named file for reading.
func (mp *Mountpoint) OpenFile(path string, flag int, perm os.FileMode) (*os.File, error) {
if err := mp.EnsureMounted(); err != nil {
return nil, err
}
return os.OpenFile(filepath.Join(mp.Root, path), flag, perm)
}
// ReadDir reads the directory named by dirname, relative to the Mountpoint's root,
// and returns a list of sorted directory entries
func (mp *Mountpoint) ReadDir(dirname string) ([]os.FileInfo, error) {
if err := mp.EnsureMounted(); err != nil {
return nil, err
}
return ioutil.ReadDir(filepath.Join(mp.Root, dirname))
}
func (store *Store) AddTag(imageId, tagName string) error { func (store *Store) AddTag(imageId, tagName string) error {
if image, err := store.Get(imageId); err != nil { if image, err := store.Get(imageId); err != nil {
return err return err

142
server/server.go
View file

@ -89,10 +89,18 @@ func (srv *Server) CmdWait(stdin io.ReadCloser, stdout io.Writer, args ...string
// 'docker info': display system-wide information. // 'docker info': display system-wide information.
func (srv *Server) CmdInfo(stdin io.ReadCloser, stdout io.Writer, args ...string) error { func (srv *Server) CmdInfo(stdin io.ReadCloser, stdout io.Writer, args ...string) error {
images, _ := srv.images.Images()
var imgcount int
if images == nil {
imgcount = 0
} else {
imgcount = len(images)
}
fmt.Fprintf(stdout, "containers: %d\nversion: %s\nimages: %d\n", fmt.Fprintf(stdout, "containers: %d\nversion: %s\nimages: %d\n",
len(srv.containers.List()), len(srv.containers.List()),
VERSION, VERSION,
0) // FIXME: Number of images imgcount)
return nil return nil
} }
@ -211,73 +219,73 @@ func (srv *Server) CmdMount(stdin io.ReadCloser, stdout io.Writer, args ...strin
return nil return nil
} }
// func (srv *Server) CmdCat(stdin io.ReadCloser, stdout io.Writer, args ...string) error { func (srv *Server) CmdCat(stdin io.ReadCloser, stdout io.Writer, args ...string) error {
// cmd := rcli.Subcmd(stdout, "cat", "[OPTIONS] CONTAINER PATH", "write the contents of a container's file to standard output") cmd := rcli.Subcmd(stdout, "cat", "[OPTIONS] CONTAINER PATH", "write the contents of a container's file to standard output")
// if err := cmd.Parse(args); err != nil { if err := cmd.Parse(args); err != nil {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// if cmd.NArg() < 2 { if cmd.NArg() < 2 {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// name, path := cmd.Arg(0), cmd.Arg(1) name, path := cmd.Arg(0), cmd.Arg(1)
// if container := srv.containers.Get(name); container != nil { if container := srv.containers.Get(name); container != nil {
// if f, err := container.Mountpoint.OpenFile(path, os.O_RDONLY, 0); err != nil { if f, err := container.Mountpoint.OpenFile(path, os.O_RDONLY, 0); err != nil {
// return err return err
// } else if _, err := io.Copy(stdout, f); err != nil { } else if _, err := io.Copy(stdout, f); err != nil {
// return err return err
// } }
// return nil return nil
// } }
// return errors.New("No such container: " + name) return errors.New("No such container: " + name)
// } }
// func (srv *Server) CmdWrite(stdin io.ReadCloser, stdout io.Writer, args ...string) error { func (srv *Server) CmdWrite(stdin io.ReadCloser, stdout io.Writer, args ...string) error {
// cmd := rcli.Subcmd(stdout, "write", "[OPTIONS] CONTAINER PATH", "write the contents of standard input to a container's file") cmd := rcli.Subcmd(stdout, "write", "[OPTIONS] CONTAINER PATH", "write the contents of standard input to a container's file")
// if err := cmd.Parse(args); err != nil { if err := cmd.Parse(args); err != nil {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// if cmd.NArg() < 2 { if cmd.NArg() < 2 {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// name, path := cmd.Arg(0), cmd.Arg(1) name, path := cmd.Arg(0), cmd.Arg(1)
// if container := srv.containers.Get(name); container != nil { if container := srv.containers.Get(name); container != nil {
// if f, err := container.Mountpoint.OpenFile(path, os.O_WRONLY|os.O_CREATE, 0600); err != nil { if f, err := container.Mountpoint.OpenFile(path, os.O_WRONLY|os.O_CREATE, 0600); err != nil {
// return err return err
// } else if _, err := io.Copy(f, stdin); err != nil { } else if _, err := io.Copy(f, stdin); err != nil {
// return err return err
// } }
// return nil return nil
// } }
// return errors.New("No such container: " + name) return errors.New("No such container: " + name)
// } }
// func (srv *Server) CmdLs(stdin io.ReadCloser, stdout io.Writer, args ...string) error { func (srv *Server) CmdLs(stdin io.ReadCloser, stdout io.Writer, args ...string) error {
// cmd := rcli.Subcmd(stdout, "ls", "[OPTIONS] CONTAINER PATH", "List the contents of a container's directory") cmd := rcli.Subcmd(stdout, "ls", "[OPTIONS] CONTAINER PATH", "List the contents of a container's directory")
// if err := cmd.Parse(args); err != nil { if err := cmd.Parse(args); err != nil {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// if cmd.NArg() < 2 { if cmd.NArg() < 2 {
// cmd.Usage() cmd.Usage()
// return nil return nil
// } }
// name, path := cmd.Arg(0), cmd.Arg(1) name, path := cmd.Arg(0), cmd.Arg(1)
// if container := srv.containers.Get(name); container != nil { if container := srv.containers.Get(name); container != nil {
// if files, err := container.Mountpoint.ReadDir(path); err != nil { if files, err := container.Mountpoint.ReadDir(path); err != nil {
// return err return err
// } else { } else {
// for _, f := range files { for _, f := range files {
// fmt.Fprintln(stdout, f.Name()) fmt.Fprintln(stdout, f.Name())
// } }
// } }
// return nil return nil
// } }
// return errors.New("No such container: " + name) return errors.New("No such container: " + name)
// } }
func (srv *Server) CmdInspect(stdin io.ReadCloser, stdout io.Writer, args ...string) error { func (srv *Server) CmdInspect(stdin io.ReadCloser, stdout io.Writer, args ...string) error {
cmd := rcli.Subcmd(stdout, "inspect", "[OPTIONS] CONTAINER", "Return low-level information on a container") cmd := rcli.Subcmd(stdout, "inspect", "[OPTIONS] CONTAINER", "Return low-level information on a container")
@ -496,7 +504,7 @@ func (srv *Server) CmdImages(stdin io.ReadCloser, stdout io.Writer, args ...stri
for idx, field := range []string{ for idx, field := range []string{
/* NAME */ name, /* NAME */ name,
/* ID */ img.Id, /* ID */ img.Id,
/* CREATED */ future.HumanDuration(time.Now().Sub(time.Now())) + " ago", // FIXME: should be img.Created /* CREATED */ future.HumanDuration(time.Now().Sub(time.Unix(img.Created, 0))) + " ago",
/* PARENT */ img.Parent, /* PARENT */ img.Parent,
} { } {
if idx == 0 { if idx == 0 {