From d7bc994a08a5dc13547b0aaf756d012e1dbba722 Mon Sep 17 00:00:00 2001 From: Ziheng Liu Date: Tue, 29 Oct 2019 17:03:38 -0400 Subject: [PATCH] awslogs & archive: prevent 2 goroutine leaks in test functions Signed-off-by: Ziheng Liu --- daemon/logger/awslogs/cloudwatchlogs_test.go | 2 +- pkg/archive/archive_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/logger/awslogs/cloudwatchlogs_test.go b/daemon/logger/awslogs/cloudwatchlogs_test.go index 420f4f6562..b9c567e085 100644 --- a/daemon/logger/awslogs/cloudwatchlogs_test.go +++ b/daemon/logger/awslogs/cloudwatchlogs_test.go @@ -345,7 +345,7 @@ func TestLogNonBlockingBufferFull(t *testing.T) { logNonBlocking: true, } stream.messages <- &logger.Message{} - errorCh := make(chan error) + errorCh := make(chan error, 1) started := make(chan bool) go func() { started <- true diff --git a/pkg/archive/archive_test.go b/pkg/archive/archive_test.go index 043853c96c..76fd59f3a6 100644 --- a/pkg/archive/archive_test.go +++ b/pkg/archive/archive_test.go @@ -217,7 +217,7 @@ func TestCmdStreamLargeStderr(t *testing.T) { if err != nil { t.Fatalf("Failed to start command: %s", err) } - errCh := make(chan error) + errCh := make(chan error, 1) go func() { _, err := io.Copy(ioutil.Discard, out) errCh <- err