From 6590ee0dfba45d7eb4ee12f72621b90294925f20 Mon Sep 17 00:00:00 2001 From: Daniel Nephin Date: Thu, 31 Aug 2017 18:19:17 -0400 Subject: [PATCH] Remove assertions that were testing CLI behaviour. These tests will be moved to docker/cli Signed-off-by: Daniel Nephin --- integration-cli/docker_cli_rename_test.go | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/integration-cli/docker_cli_rename_test.go b/integration-cli/docker_cli_rename_test.go index d043620d4f..de277596fe 100644 --- a/integration-cli/docker_cli_rename_test.go +++ b/integration-cli/docker_cli_rename_test.go @@ -69,6 +69,7 @@ func (s *DockerSuite) TestRenameCheckNames(c *check.C) { }) } +// TODO: move to unit test func (s *DockerSuite) TestRenameInvalidName(c *check.C) { runSleepingContainer(c, "--name", "myname") @@ -76,18 +77,6 @@ func (s *DockerSuite) TestRenameInvalidName(c *check.C) { c.Assert(err, checker.NotNil, check.Commentf("Renaming container to invalid name should have failed: %s", out)) c.Assert(out, checker.Contains, "Invalid container name", check.Commentf("%v", err)) - out, _, err = dockerCmdWithError("rename", "myname") - c.Assert(err, checker.NotNil, check.Commentf("Renaming container to invalid name should have failed: %s", out)) - c.Assert(out, checker.Contains, "requires exactly 2 argument(s).", check.Commentf("%v", err)) - - out, _, err = dockerCmdWithError("rename", "myname", "") - c.Assert(err, checker.NotNil, check.Commentf("Renaming container to invalid name should have failed: %s", out)) - c.Assert(out, checker.Contains, "may be empty", check.Commentf("%v", err)) - - out, _, err = dockerCmdWithError("rename", "", "newname") - c.Assert(err, checker.NotNil, check.Commentf("Renaming container with empty name should have failed: %s", out)) - c.Assert(out, checker.Contains, "may be empty", check.Commentf("%v", err)) - out, _ = dockerCmd(c, "ps", "-a") c.Assert(out, checker.Contains, "myname", check.Commentf("Output of docker ps should have included 'myname': %s", out)) }