diff --git a/libnetwork/network.go b/libnetwork/network.go index 318c3956c0..70c55844f1 100644 --- a/libnetwork/network.go +++ b/libnetwork/network.go @@ -1156,6 +1156,18 @@ func (n *network) createEndpoint(name string, options ...EndpointOption) (Endpoi ep.releaseAddress() } }() + // Moving updateToSTore before calling addEndpoint so that we shall clean up VETH interfaces in case + // DockerD get killed between addEndpoint and updateSTore call + if err = n.getController().updateToStore(ep); err != nil { + return nil, err + } + defer func() { + if err != nil { + if e := n.getController().deleteFromStore(ep); e != nil { + logrus.Warnf("error rolling back endpoint %s from store: %v", name, e) + } + } + }() if err = n.addEndpoint(ep); err != nil { return nil, err @@ -1172,17 +1184,6 @@ func (n *network) createEndpoint(name string, options ...EndpointOption) (Endpoi return nil, err } - if err = n.getController().updateToStore(ep); err != nil { - return nil, err - } - defer func() { - if err != nil { - if e := n.getController().deleteFromStore(ep); e != nil { - logrus.Warnf("error rolling back endpoint %s from store: %v", name, e) - } - } - }() - // Watch for service records n.getController().watchSvcRecord(ep) defer func() {