kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #44375 from thaJeztah/improve_TestParseLink

Browse source 
opts: TestParseLink(): add test-case for legacy format
This commit is contained in:
Brian Goff 2022-11-01 09:16:26 -07:00 • committed by GitHub
commit 6743bf3173
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
opts/opts_test.go
View file

@ -307,33 +307,30 @@ func TestNamedMapOpts(t *testing.T) {
}
func TestParseLink(t *testing.T) {
name, alias, err := ParseLink("name:alias")
if err != nil {
t.Fatalf("Expected not to error out on a valid name:alias format but got: %v", err)
}
if name != "name" {
t.Fatalf("Link name should have been name, got %s instead", name)
}
if alias != "alias" {
t.Fatalf("Link alias should have been alias, got %s instead", alias)
}
// short format definition
name, alias, err = ParseLink("name")
if err != nil {
t.Fatalf("Expected not to error out on a valid name only format but got: %v", err)
}
if name != "name" {
t.Fatalf("Link name should have been name, got %s instead", name)
}
if alias != "name" {
t.Fatalf("Link alias should have been name, got %s instead", alias)
}
// empty string link definition is not allowed
if _, _, err := ParseLink(""); err == nil || !strings.Contains(err.Error(), "empty string specified for links") {
t.Fatalf("Expected error 'empty string specified for links' but got: %v", err)
}
// more than two colons are not allowed
if _, _, err := ParseLink("link:alias:wrong"); err == nil || !strings.Contains(err.Error(), "bad format for links: link:alias:wrong") {
t.Fatalf("Expected error 'bad format for links: link:alias:wrong' but got: %v", err)
}
t.Run("name and alias", func(t *testing.T) {
name, alias, err := ParseLink("name:alias")
assert.Check(t, err)
assert.Check(t, is.Equal(name, "name"))
assert.Check(t, is.Equal(alias, "alias"))
})
t.Run("short format", func(t *testing.T) {
name, alias, err := ParseLink("name")
assert.Check(t, err)
assert.Check(t, is.Equal(name, "name"))
assert.Check(t, is.Equal(alias, "name"))
})
t.Run("empty string", func(t *testing.T) {
_, _, err := ParseLink("")
assert.Check(t, is.Error(err, "empty string specified for links"))
})
t.Run("more than two colons", func(t *testing.T) {
_, _, err := ParseLink("link:alias:wrong")
assert.Check(t, is.Error(err, "bad format for links: link:alias:wrong"))
})
t.Run("legacy format", func(t *testing.T) {
name, alias, err := ParseLink("/foo:/c1/bar")
assert.Check(t, err)
assert.Check(t, is.Equal(name, "foo"))
assert.Check(t, is.Equal(alias, "bar"))
})
}