kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Fix the brittle errorstring-to-httperror recognition code which in turn is required by autopull (the client issues a pull if container creation returns 404)

Browse source
This commit is contained in:
Solomon Hykes 2013-11-14 23:53:43 +00:00
parent 629c6e3649
commit 693ff4d2ae
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
api.go
View file

@ -61,7 +61,10 @@ func parseMultipartForm(r *http.Request) error {
func httpError(w http.ResponseWriter, err error) { func httpError(w http.ResponseWriter, err error) {
statusCode := http.StatusInternalServerError statusCode := http.StatusInternalServerError
if strings.HasPrefix(err.Error(), "No such") { // FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types, we should
// create appropriate error types with clearly defined meaning.
if strings.Contains(err.Error(), "No such") {
statusCode = http.StatusNotFound statusCode = http.StatusNotFound
} else if strings.HasPrefix(err.Error(), "Bad parameter") { } else if strings.HasPrefix(err.Error(), "Bad parameter") {
statusCode = http.StatusBadRequest statusCode = http.StatusBadRequest