mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Use assertions in image package unit tests.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
This commit is contained in:
Daniel Nephin
parent
9ea5e02e92
commit
69d7362058
3 changed files with 192 additions and 451 deletions
|
|
@ -1,292 +1,150 @@
|
|||
package image
|
||||
|
||||
import (
|
||||
"io/ioutil"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"github.com/docker/docker/layer"
|
||||
"github.com/docker/docker/pkg/testutil/assert"
|
||||
"github.com/opencontainers/go-digest"
|
||||
)
|
||||
|
||||
func TestRestore(t *testing.T) {
|
||||
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer os.RemoveAll(tmpdir)
|
||||
fs, err := NewFSStoreBackend(tmpdir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
fs, cleanup := defaultFSStoreBackend(t)
|
||||
defer cleanup()
|
||||
|
||||
id1, err := fs.Set([]byte(`{"comment": "abc", "rootfs": {"type": "layers"}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
_, err = fs.Set([]byte(`invalid`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
id2, err := fs.Set([]byte(`{"comment": "def", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
err = fs.SetMetadata(id2, "parent", []byte(id1))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
imgs := is.Map()
|
||||
if actual, expected := len(imgs), 2; actual != expected {
|
||||
t.Fatalf("invalid images length, expected 2, got %q", len(imgs))
|
||||
}
|
||||
assert.Equal(t, len(is.Map()), 2)
|
||||
|
||||
img1, err := is.Get(ID(id1))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if actual, expected := img1.computedID, ID(id1); actual != expected {
|
||||
t.Fatalf("invalid image ID: expected %q, got %q", expected, actual)
|
||||
}
|
||||
|
||||
if actual, expected := img1.computedID.String(), string(id1); actual != expected {
|
||||
t.Fatalf("invalid image ID string: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, img1.computedID, ID(id1))
|
||||
assert.Equal(t, img1.computedID.String(), string(id1))
|
||||
|
||||
img2, err := is.Get(ID(id2))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if actual, expected := img1.Comment, "abc"; actual != expected {
|
||||
t.Fatalf("invalid comment for image1: expected %q, got %q", expected, actual)
|
||||
}
|
||||
|
||||
if actual, expected := img2.Comment, "def"; actual != expected {
|
||||
t.Fatalf("invalid comment for image2: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, img1.Comment, "abc")
|
||||
assert.Equal(t, img2.Comment, "def")
|
||||
|
||||
p, err := is.GetParent(ID(id1))
|
||||
if err == nil {
|
||||
t.Fatal("expected error for getting parent")
|
||||
}
|
||||
assert.Error(t, err, "no such file")
|
||||
|
||||
p, err = is.GetParent(ID(id2))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if actual, expected := p, ID(id1); actual != expected {
|
||||
t.Fatalf("invalid parent: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, p, ID(id1))
|
||||
|
||||
children := is.Children(ID(id1))
|
||||
if len(children) != 1 {
|
||||
t.Fatalf("invalid children length: %q", len(children))
|
||||
}
|
||||
if actual, expected := children[0], ID(id2); actual != expected {
|
||||
t.Fatalf("invalid child for id1: expected %q, got %q", expected, actual)
|
||||
}
|
||||
|
||||
heads := is.Heads()
|
||||
if actual, expected := len(heads), 1; actual != expected {
|
||||
t.Fatalf("invalid images length: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.Equal(t, len(children), 1)
|
||||
assert.Equal(t, children[0], ID(id2))
|
||||
assert.Equal(t, len(is.Heads()), 1)
|
||||
|
||||
sid1, err := is.Search(string(id1)[:10])
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if actual, expected := sid1, ID(id1); actual != expected {
|
||||
t.Fatalf("searched ID mismatch: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, sid1, ID(id1))
|
||||
|
||||
sid1, err = is.Search(digest.Digest(id1).Hex()[:6])
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if actual, expected := sid1, ID(id1); actual != expected {
|
||||
t.Fatalf("searched ID mismatch: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, sid1, ID(id1))
|
||||
|
||||
invalidPattern := digest.Digest(id1).Hex()[1:6]
|
||||
_, err = is.Search(invalidPattern)
|
||||
if err == nil {
|
||||
t.Fatalf("expected search for %q to fail", invalidPattern)
|
||||
}
|
||||
|
||||
assert.Error(t, err, "No such image")
|
||||
}
|
||||
|
||||
func TestAddDelete(t *testing.T) {
|
||||
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer os.RemoveAll(tmpdir)
|
||||
fs, err := NewFSStoreBackend(tmpdir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
is, cleanup := defaultImageStore(t)
|
||||
defer cleanup()
|
||||
|
||||
id1, err := is.Create([]byte(`{"comment": "abc", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if actual, expected := id1, ID("sha256:8d25a9c45df515f9d0fe8e4a6b1c64dd3b965a84790ddbcc7954bb9bc89eb993"); actual != expected {
|
||||
t.Fatalf("create ID mismatch: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, id1, ID("sha256:8d25a9c45df515f9d0fe8e4a6b1c64dd3b965a84790ddbcc7954bb9bc89eb993"))
|
||||
|
||||
img, err := is.Get(id1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if actual, expected := img.Comment, "abc"; actual != expected {
|
||||
t.Fatalf("invalid comment in image: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, img.Comment, "abc")
|
||||
|
||||
id2, err := is.Create([]byte(`{"comment": "def", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
err = is.SetParent(id2, id1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
pid1, err := is.GetParent(id2)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if actual, expected := pid1, id1; actual != expected {
|
||||
t.Fatalf("invalid parent for image: expected %q, got %q", expected, actual)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, pid1, id1)
|
||||
|
||||
_, err = is.Delete(id1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
_, err = is.Get(id1)
|
||||
if err == nil {
|
||||
t.Fatalf("expected get for deleted image %q to fail", id1)
|
||||
}
|
||||
_, err = is.Get(id2)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
pid1, err = is.GetParent(id2)
|
||||
if err == nil {
|
||||
t.Fatalf("expected parent check for image %q to fail, got %q", id2, pid1)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
_, err = is.Get(id1)
|
||||
assert.Error(t, err, "no such file or directory")
|
||||
|
||||
_, err = is.Get(id2)
|
||||
assert.NilError(t, err)
|
||||
|
||||
_, err = is.GetParent(id2)
|
||||
assert.Error(t, err, "no such file or directory")
|
||||
}
|
||||
|
||||
func TestSearchAfterDelete(t *testing.T) {
|
||||
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer os.RemoveAll(tmpdir)
|
||||
fs, err := NewFSStoreBackend(tmpdir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
is, cleanup := defaultImageStore(t)
|
||||
defer cleanup()
|
||||
|
||||
id, err := is.Create([]byte(`{"comment": "abc", "rootfs": {"type": "layers"}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
id1, err := is.Search(string(id)[:15])
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
assert.Equal(t, id1, id)
|
||||
|
||||
if actual, expected := id1, id; expected != actual {
|
||||
t.Fatalf("wrong id returned from search: expected %q, got %q", expected, actual)
|
||||
}
|
||||
_, err = is.Delete(id)
|
||||
assert.NilError(t, err)
|
||||
|
||||
if _, err := is.Delete(id); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if _, err := is.Search(string(id)[:15]); err == nil {
|
||||
t.Fatal("expected search after deletion to fail")
|
||||
}
|
||||
_, err = is.Search(string(id)[:15])
|
||||
assert.Error(t, err, "No such image")
|
||||
}
|
||||
|
||||
func TestParentReset(t *testing.T) {
|
||||
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer os.RemoveAll(tmpdir)
|
||||
fs, err := NewFSStoreBackend(tmpdir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
is, cleanup := defaultImageStore(t)
|
||||
defer cleanup()
|
||||
|
||||
id, err := is.Create([]byte(`{"comment": "abc1", "rootfs": {"type": "layers"}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
id2, err := is.Create([]byte(`{"comment": "abc2", "rootfs": {"type": "layers"}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
id3, err := is.Create([]byte(`{"comment": "abc3", "rootfs": {"type": "layers"}}`))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, err)
|
||||
|
||||
if err := is.SetParent(id, id2); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
assert.NilError(t, is.SetParent(id, id2))
|
||||
assert.Equal(t, len(is.Children(id2)), 1)
|
||||
|
||||
ids := is.Children(id2)
|
||||
if actual, expected := len(ids), 1; expected != actual {
|
||||
t.Fatalf("wrong number of children: %d, got %d", expected, actual)
|
||||
}
|
||||
assert.NilError(t, is.SetParent(id, id3))
|
||||
assert.Equal(t, len(is.Children(id2)), 0)
|
||||
assert.Equal(t, len(is.Children(id3)), 1)
|
||||
}
|
||||
|
||||
if err := is.SetParent(id, id3); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
func defaultImageStore(t *testing.T) (Store, func()) {
|
||||
fsBackend, cleanup := defaultFSStoreBackend(t)
|
||||
|
||||
ids = is.Children(id2)
|
||||
if actual, expected := len(ids), 0; expected != actual {
|
||||
t.Fatalf("wrong number of children after parent reset: %d, got %d", expected, actual)
|
||||
}
|
||||
|
||||
ids = is.Children(id3)
|
||||
if actual, expected := len(ids), 1; expected != actual {
|
||||
t.Fatalf("wrong number of children after parent reset: %d, got %d", expected, actual)
|
||||
}
|
||||
store, err := NewImageStore(fsBackend, &mockLayerGetReleaser{})
|
||||
assert.NilError(t, err)
|
||||
|
||||
return store, cleanup
|
||||
}
|
||||
|
||||
type mockLayerGetReleaser struct{}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue