From 6ff727b13c52658e20bb63494d595beeeb5407ea Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 28 Aug 2019 17:37:34 +0200 Subject: [PATCH] TestWalkValues: add missing error-check (errcheck) ``` api/types/filters/parse_test.go:340:14: Error return value of `f.WalkValues` is not checked (errcheck) ``` Signed-off-by: Sebastiaan van Stijn --- api/types/filters/parse_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/api/types/filters/parse_test.go b/api/types/filters/parse_test.go index 6bca7d8721..aadea040d8 100644 --- a/api/types/filters/parse_test.go +++ b/api/types/filters/parse_test.go @@ -337,14 +337,17 @@ func TestWalkValues(t *testing.T) { f.Add("status", "running") f.Add("status", "paused") - f.WalkValues("status", func(value string) error { + err := f.WalkValues("status", func(value string) error { if value != "running" && value != "paused" { t.Fatalf("Unexpected value %s", value) } return nil }) + if err != nil { + t.Fatalf("Expected no error, got %v", err) + } - err := f.WalkValues("status", func(value string) error { + err = f.WalkValues("status", func(value string) error { return errors.New("return") }) if err == nil {