From 709478c8a3bfaf935dcb37b4f4e0085832868eb7 Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Tue, 31 May 2016 04:12:25 +0000 Subject: [PATCH] Fix pkg/jsonmessage.TestProgress panic Fix #23112 Signed-off-by: Akihiro Suda --- pkg/jsonmessage/jsonmessage_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/pkg/jsonmessage/jsonmessage_test.go b/pkg/jsonmessage/jsonmessage_test.go index 558effcc3b..479857d904 100644 --- a/pkg/jsonmessage/jsonmessage_test.go +++ b/pkg/jsonmessage/jsonmessage_test.go @@ -19,6 +19,11 @@ func TestError(t *testing.T) { } func TestProgress(t *testing.T) { + termsz, err := term.GetWinsize(0) + if err != nil { + // we can safely ignore the err here + termsz = nil + } jp := JSONProgress{} if jp.String() != "" { t.Fatalf("Expected empty string, got '%s'", jp.String()) @@ -31,6 +36,9 @@ func TestProgress(t *testing.T) { } expectedStart := "[==========> ] 20 B/100 B" + if termsz != nil && termsz.Width <= 110 { + expectedStart = " 20 B/100 B" + } jp3 := JSONProgress{Current: 20, Total: 100, Start: time.Now().Unix()} // Just look at the start of the string // (the remaining time is really hard to test -_-) @@ -39,6 +47,9 @@ func TestProgress(t *testing.T) { } expected = "[=========================> ] 50 B/100 B" + if termsz != nil && termsz.Width <= 110 { + expected = " 50 B/100 B" + } jp4 := JSONProgress{Current: 50, Total: 100} if jp4.String() != expected { t.Fatalf("Expected %q, got %q", expected, jp4.String()) @@ -46,6 +57,9 @@ func TestProgress(t *testing.T) { // this number can't be negative gh#7136 expected = "[==================================================>] 50 B" + if termsz != nil && termsz.Width <= 110 { + expected = " 50 B" + } jp5 := JSONProgress{Current: 50, Total: 40} if jp5.String() != expected { t.Fatalf("Expected %q, got %q", expected, jp5.String())