mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Fix issue reloading mount options on restart
On daemon restart the local volume driver will read options that it
persisted to disk, however it was reading an incorrect path, causing
volume options to be silently ignored after a daemon restart.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit c560dd9686
)
Signed-off-by: Tibor Vass <tibor@docker.com>
This commit is contained in:
parent
aaf3a81086
commit
70f0f7a20e
2 changed files with 18 additions and 1 deletions
|
@ -88,7 +88,9 @@ func New(scope string, rootUID, rootGID int) (*Root, error) {
|
|||
path: r.DataPath(name),
|
||||
}
|
||||
r.volumes[name] = v
|
||||
if b, err := ioutil.ReadFile(filepath.Join(name, "opts.json")); err == nil {
|
||||
optsFilePath := filepath.Join(rootDirectory, name, "opts.json")
|
||||
if b, err := ioutil.ReadFile(optsFilePath); err == nil {
|
||||
v.opts = &optsConfig{}
|
||||
if err := json.Unmarshal(b, v.opts); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
|
|
@ -3,6 +3,7 @@ package local
|
|||
import (
|
||||
"io/ioutil"
|
||||
"os"
|
||||
"reflect"
|
||||
"runtime"
|
||||
"strings"
|
||||
"testing"
|
||||
|
@ -246,4 +247,18 @@ func TestCreateWithOpts(t *testing.T) {
|
|||
if !mounted {
|
||||
t.Fatal("expected mount to still be active")
|
||||
}
|
||||
|
||||
r, err = New(rootDir, 0, 0)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
v2, exists := r.volumes["test"]
|
||||
if !exists {
|
||||
t.Fatal("missing volume on restart")
|
||||
}
|
||||
|
||||
if !reflect.DeepEqual(v.opts, v2.opts) {
|
||||
t.Fatal("missing volume options on restart")
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue