From 7381fffb2f0a0307ef1575a299028d036f24088f Mon Sep 17 00:00:00 2001 From: Aaron Lehmann Date: Wed, 5 Apr 2017 16:59:32 -0700 Subject: [PATCH] api: Don't include stack traces with errors Signed-off-by: Aaron Lehmann --- api/server/server.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/api/server/server.go b/api/server/server.go index d1d4cf417c..2e5f9632d5 100644 --- a/api/server/server.go +++ b/api/server/server.go @@ -139,11 +139,9 @@ func (s *Server) makeHTTPHandler(handler httputils.APIFunc) http.HandlerFunc { if err := handlerFunc(ctx, w, r, vars); err != nil { statusCode := httputils.GetHTTPErrorStatusCode(err) - errFormat := "%v" - if statusCode == http.StatusInternalServerError { - errFormat = "%+v" + if statusCode >= 500 { + logrus.Errorf("Handler for %s %s returned error: %v", r.Method, r.URL.Path, err) } - logrus.Errorf("Handler for %s %s returned error: "+errFormat, r.Method, r.URL.Path, err) httputils.MakeErrorHandler(err)(w, r) } }