kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

api/server/router/grpc: fix some nits in NewRouter()

Browse source 
These were changes I drafted when reviewing 7c731e02a9,
and had these stashed in my local git;

- rename receiver to prevent "unconsistent receiver name" warnings
- make NewRouter() slightly more idiomatic, and wrap the options,
  to make them easier to read.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2022-04-07 16:06:15 +02:00
parent a461373146
commit 758714ed6d
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
api/server/router/grpc/grpc.go
View file

@ -15,12 +15,12 @@ type grpcRouter struct {
// NewRouter initializes a new grpc http router // NewRouter initializes a new grpc http router
func NewRouter(backends ...Backend) router.Router { func NewRouter(backends ...Backend) router.Router {
opts := []grpc.ServerOption{grpc.UnaryInterceptor(grpcerrors.UnaryServerInterceptor), grpc.StreamInterceptor(grpcerrors.StreamServerInterceptor)}
server := grpc.NewServer(opts...)
r := &grpcRouter{ r := &grpcRouter{
h2Server: &http2.Server{}, h2Server: &http2.Server{},
grpcServer: server, grpcServer: grpc.NewServer(
grpc.UnaryInterceptor(grpcerrors.UnaryServerInterceptor),
grpc.StreamInterceptor(grpcerrors.StreamServerInterceptor),
),
} }
for _, b := range backends { for _, b := range backends {
b.RegisterGRPC(r.grpcServer) b.RegisterGRPC(r.grpcServer)
@ -30,12 +30,12 @@ func NewRouter(backends ...Backend) router.Router {
} }
// Routes returns the available routers to the session controller // Routes returns the available routers to the session controller
func (r *grpcRouter) Routes() []router.Route { func (gr *grpcRouter) Routes() []router.Route {
return r.routes return gr.routes
} }
func (r *grpcRouter) initRoutes() { func (gr *grpcRouter) initRoutes() {
r.routes = []router.Route{ gr.routes = []router.Route{
router.NewPostRoute("/grpc", r.serveGRPC), router.NewPostRoute("/grpc", gr.serveGRPC),
} }
} }