kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #29903 from Microsoft/jjh/volumetest-tp5

Browse source 
Windows: Fix TP5 volume unit tests TODOs
This commit is contained in:
Vincent Demeester 2017-01-05 09:53:31 +01:00 committed by GitHub
commit 7ad34996bc
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
volume/volume_test.go
View file

@ -22,7 +22,6 @@ func TestParseMountRaw(t *testing.T) {
`d:`,
`d:\path`,
`d:\path with space`,
// TODO Windows post TP5 - readonly support `d:\pathandmode:ro`,
`c:\:d:\`,
`c:\windows\:d:`,
`c:\windows:d:\s p a c e`,
@ -33,9 +32,9 @@ func TestParseMountRaw(t *testing.T) {
`name:D:`,
`name:D::rW`,
`name:D::RW`,
// TODO Windows post TP5 - readonly support `name:D::RO`,
`name:D::RO`,
`c:/:d:/forward/slashes/are/good/too`,
// TODO Windows post TP5 - readonly support `c:/:d:/including with/spaces:ro`,
`c:/:d:/including with/spaces:ro`,
`c:\Windows`, // With capital
`c:\Program Files (x86)`, // With capitals and brackets
}
@ -59,6 +58,7 @@ func TestParseMountRaw(t *testing.T) {
`name?:d:`: `invalid volume specification`,
`name/:d:`: `invalid volume specification`,
`d:\pathandmode:rw`: `invalid volume specification`,
`d:\pathandmode:ro`: `invalid volume specification`,
`con:d:`: `cannot be a reserved word for Windows filenames`,
`PRN:d:`: `cannot be a reserved word for Windows filenames`,
`aUx:d:`: `cannot be a reserved word for Windows filenames`,
@ -157,12 +157,12 @@ func TestParseMountRawSplit(t *testing.T) {
cases = []testParseMountRaw{
{`c:\:d:`, "local", `d:`, `c:\`, ``, "", true, false},
{`c:\:d:\`, "local", `d:\`, `c:\`, ``, "", true, false},
// TODO Windows post TP5 - Add readonly support {`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false},
{`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false},
{`c:\:d:\:rw`, "local", `d:\`, `c:\`, ``, "", true, false},
{`c:\:d:\:foo`, "local", `d:\`, `c:\`, ``, "", false, true},
{`name:d::rw`, "local", `d:`, ``, `name`, "local", true, false},
{`name:d:`, "local", `d:`, ``, `name`, "local", true, false},
// TODO Windows post TP5 - Add readonly support {`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false},
{`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false},
{`name:c:`, "", ``, ``, ``, "", true, true},
{`driver/name:c:`, "", ``, ``, ``, "", true, true},
}