From a0a5ec4c6d18debd1ef94fbcc8096dfb8c561a7b Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 30 Oct 2019 17:42:52 +0100 Subject: [PATCH] Integration: skip TestInfoDebug on Windows The test starts a new daemon, but attempts to run it with overlay2, and using a unix:// socket, which doesn't really work on Windows. ``` 00:14:14.623 --- FAIL: TestInfoDebug (0.01s) 00:14:14.623 info_test.go:75: [dbe75bf7729f3] failed to start daemon with arguments [--containerd /var/run/docker/containerd/containerd.sock --data-root D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoDebug\dbe75bf7729f3\root --exec-root C:\windows\TEMP\dxr\dbe75bf7729f3 --pidfile D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoDebug\dbe75bf7729f3\docker.pid --userland-proxy=true --containerd-namespace dbe75bf7729f3 --containerd-plugins-namespace dbe75bf7729f3p --host unix://C:\windows\TEMP\docker-integration\dbe75bf7729f3.sock --storage-driver overlay2 --debug] : protocol not available 00:14:14.623 === RUN TestInfoInsecureRegistries 00:14:14.623 --- FAIL: TestInfoInsecureRegistries (0.00s) 00:14:14.623 info_test.go:100: [d3c745c16a39c] failed to start daemon with arguments [--containerd /var/run/docker/containerd/containerd.sock --data-root D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoInsecureRegistries\d3c745c16a39c\root --exec-root C:\windows\TEMP\dxr\d3c745c16a39c --pidfile D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoInsecureRegistries\d3c745c16a39c\docker.pid --userland-proxy=true --containerd-namespace d3c745c16a39c --containerd-plugins-namespace d3c745c16a39cp --host unix://C:\windows\TEMP\docker-integration\d3c745c16a39c.sock --debug --storage-driver overlay2 --insecure-registry=192.168.1.0/24 --insecure-registry=insecurehost.com:5000] : protocol not available 00:14:14.623 === RUN TestInfoRegistryMirrors 00:14:14.623 --- FAIL: TestInfoRegistryMirrors (0.01s) 00:14:14.623 info_test.go:124: [d277126ad0515] failed to start daemon with arguments [--containerd /var/run/docker/containerd/containerd.sock --data-root D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoRegistryMirrors\d277126ad0515\root --exec-root C:\windows\TEMP\dxr\d277126ad0515 --pidfile D:\gopath\src\github.com\docker\docker\bundles\tmp\TestInfoRegistryMirrors\d277126ad0515\docker.pid --userland-proxy=true --containerd-namespace d277126ad0515 --containerd-plugins-namespace d277126ad0515p --host unix://C:\windows\TEMP\docker-integration\d277126ad0515.sock --debug --storage-driver overlay2 --registry-mirror=https://192.168.1.2 --registry-mirror=http://registry.mirror.com:5000] : protocol not available ``` Signed-off-by: Sebastiaan van Stijn --- integration/system/info_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/integration/system/info_test.go b/integration/system/info_test.go index e47b0ed4ea..0124f126fd 100644 --- a/integration/system/info_test.go +++ b/integration/system/info_test.go @@ -70,6 +70,7 @@ func TestInfoAPIWarnings(t *testing.T) { func TestInfoDebug(t *testing.T) { skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon") + skip.If(t, testEnv.DaemonInfo.OSType == "windows", "FIXME: test starts daemon with -H unix://.....") d := daemon.New(t) d.Start(t, "--debug")