mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Raise a more relevant error when dockerd is not available on the platform.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
This commit is contained in:
parent
9db86a38cd
commit
8983d42988
5 changed files with 15 additions and 4 deletions
|
@ -1,11 +1,16 @@
|
||||||
|
// +build !daemon
|
||||||
|
|
||||||
package main
|
package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"runtime"
|
||||||
|
"strings"
|
||||||
)
|
)
|
||||||
|
|
||||||
// CmdDaemon reports on an error on windows, because there is no exec
|
// CmdDaemon reports on an error on windows, because there is no exec
|
||||||
func (p DaemonProxy) CmdDaemon(args ...string) error {
|
func (p DaemonProxy) CmdDaemon(args ...string) error {
|
||||||
return fmt.Errorf(
|
return fmt.Errorf(
|
||||||
"`docker daemon` does not exist on windows. Please run `dockerd` directly")
|
"`docker daemon` is not supported on %s. Please run `dockerd` directly",
|
||||||
|
strings.Title(runtime.GOOS))
|
||||||
}
|
}
|
|
@ -1,3 +1,5 @@
|
||||||
|
// +build !daemon
|
||||||
|
|
||||||
package main
|
package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
@ -9,7 +11,7 @@ func TestCmdDaemon(t *testing.T) {
|
||||||
proxy := NewDaemonProxy()
|
proxy := NewDaemonProxy()
|
||||||
err := proxy.CmdDaemon("--help")
|
err := proxy.CmdDaemon("--help")
|
||||||
if err == nil {
|
if err == nil {
|
||||||
t.Fatal("Expected CmdDaemon to fail in Windows.")
|
t.Fatal("Expected CmdDaemon to fail on Windows.")
|
||||||
}
|
}
|
||||||
|
|
||||||
if !strings.Contains(err.Error(), "Please run `dockerd`") {
|
if !strings.Contains(err.Error(), "Please run `dockerd`") {
|
|
@ -1,4 +1,4 @@
|
||||||
// +build !windows
|
// +build daemon
|
||||||
|
|
||||||
package main
|
package main
|
||||||
|
|
||||||
|
|
|
@ -127,6 +127,7 @@ if [ "$DOCKER_EXPERIMENTAL" ]; then
|
||||||
DOCKER_BUILDTAGS+=" experimental"
|
DOCKER_BUILDTAGS+=" experimental"
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
DOCKER_BUILDTAGS+=" daemon"
|
||||||
if pkg-config 'libsystemd >= 209' 2> /dev/null ; then
|
if pkg-config 'libsystemd >= 209' 2> /dev/null ; then
|
||||||
DOCKER_BUILDTAGS+=" journald"
|
DOCKER_BUILDTAGS+=" journald"
|
||||||
elif pkg-config 'libsystemd-journal' 2> /dev/null ; then
|
elif pkg-config 'libsystemd-journal' 2> /dev/null ; then
|
||||||
|
|
|
@ -35,7 +35,10 @@ for platform in $DOCKER_CROSSPLATFORMS; do
|
||||||
fi
|
fi
|
||||||
|
|
||||||
if [ -z "${daemonSupporting[$platform]}" ]; then
|
if [ -z "${daemonSupporting[$platform]}" ]; then
|
||||||
export LDFLAGS_STATIC_DOCKER="" # we just need a simple client for these platforms
|
# we just need a simple client for these platforms
|
||||||
|
export LDFLAGS_STATIC_DOCKER=""
|
||||||
|
# remove the "daemon" build tag from platforms that aren't supported
|
||||||
|
export BUILDFLAGS=( "${ORIG_BUILDFLAGS[@]/ daemon/}" )
|
||||||
source "${MAKEDIR}/binary-client"
|
source "${MAKEDIR}/binary-client"
|
||||||
else
|
else
|
||||||
source "${MAKEDIR}/binary-client"
|
source "${MAKEDIR}/binary-client"
|
||||||
|
|
Loading…
Reference in a new issue