From 898e84d5fd1ad502632eb4082b7be37a65599a3b Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Wed, 22 Mar 2017 14:43:33 -0400 Subject: [PATCH] Remove undeeded and broken selinux relabel call The call is not needed here and wouldn't really work since `Source` in this case is a volume name. Further we don't neccessarily even have a volume path at this time since the volume hasn't been mounted yet. The volume will be relabled either: 1. When data gets copied to it from the image (if applicable) -- https://github.com/docker/docker/blob/master/container/container_unix.go#L196 2. When the container is started -- https://github.com/docker/docker/blob/master/daemon/oci_linux.go#L737 Signed-off-by: Brian Goff --- daemon/volumes.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/daemon/volumes.go b/daemon/volumes.go index e7f386951e..a6faf7b165 100644 --- a/daemon/volumes.go +++ b/daemon/volumes.go @@ -15,7 +15,6 @@ import ( "github.com/docker/docker/container" "github.com/docker/docker/volume" "github.com/docker/docker/volume/drivers" - "github.com/opencontainers/runc/libcontainer/label" ) var ( @@ -193,9 +192,6 @@ func (daemon *Daemon) registerMountPoints(container *container.Container, hostCo return err } - if err := label.Relabel(mp.Source, container.MountLabel, false); err != nil { - return err - } mp.Volume = v mp.Name = v.Name() mp.Driver = v.DriverName()