Merge pull request #14639 from calavera/fix_read_write_check

Fix read-write check for volumes.

daemon/volumes.go

@@ -172,7 +172,7 @@ func (daemon *Daemon) registerMountPoints(container *Container, hostConfig *runc
 			cp := &mountPoint{
 				Name:        m.Name,
 				Source:      m.Source,
-				RW:          m.RW && !roModes[mode],
+				RW:          m.RW && volume.ReadWrite(mode),
 				Driver:      m.Driver,
 				Destination: m.Destination,
 			}

volume/volume.go

@@ -50,3 +50,8 @@ var roModes = map[string]bool{
 func ValidateMountMode(mode string) (bool, bool) {
 	return roModes[mode] || rwModes[mode], rwModes[mode]
 }
+
+// ReadOnly tells you if a mode string is a valid read-only mode or not.
+func ReadWrite(mode string) bool {
+	return rwModes[mode]
+}