kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #40867 from BurtonQin/double-lock

Browse source 
plugin: Add No-Lock version of resolvePluginID to fix double Rlock
This commit is contained in:
Sebastiaan van Stijn 2020-05-15 18:07:39 +02:00 committed by GitHub
commit 8e2e2bdb9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugin/store.go
View file

@ -249,10 +249,8 @@ func (ps *Store) CallHandler(p *v2.Plugin) {
} }
} }
// resolvePluginID must be protected by ps.RLock
func (ps *Store) resolvePluginID(idOrName string) (string, error) { func (ps *Store) resolvePluginID(idOrName string) (string, error) {
ps.RLock() // todo: fix
defer ps.RUnlock()
if validFullID.MatchString(idOrName) { if validFullID.MatchString(idOrName) {
return idOrName, nil return idOrName, nil
} }