From 8f1b793528e01004e4a40fe4ef835e235282b2f4 Mon Sep 17 00:00:00 2001 From: Madhu Venugopal Date: Thu, 22 Dec 2016 10:26:04 -0800 Subject: [PATCH] Add a GetAll function that returns only managed plugins supported by V2 The current GetAll handles both V2 and legacy plugins. Also due to the nature of V1 plugins, it also loads them. This causes problems when loading is not required. Hence adding an independent API that will return only the plugins that are loaded using v2 mangaed plugins. Signed-off-by: Madhu Venugopal --- pkg/plugingetter/getter.go | 1 + plugin/store/store.go | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/pkg/plugingetter/getter.go b/pkg/plugingetter/getter.go index 46d4e38266..6c2c82c670 100644 --- a/pkg/plugingetter/getter.go +++ b/pkg/plugingetter/getter.go @@ -30,5 +30,6 @@ type CountedPlugin interface { type PluginGetter interface { Get(name, capability string, mode int) (CompatPlugin, error) GetAllByCap(capability string) ([]CompatPlugin, error) + GetAllManagedPluginsByCap(capability string) []CompatPlugin Handle(capability string, callback func(string, *plugins.Client)) } diff --git a/plugin/store/store.go b/plugin/store/store.go index 36474d7635..460b63e51c 100644 --- a/plugin/store/store.go +++ b/plugin/store/store.go @@ -206,6 +206,11 @@ func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlug return nil, err } +// GetAllManagedPluginsByCap returns a list of managed plugins matching the given capability. +func (ps *Store) GetAllManagedPluginsByCap(capability string) []plugingetter.CompatPlugin { + return ps.getAllByCap(capability) +} + // GetAllByCap returns a list of enabled plugins matching the given capability. func (ps *Store) GetAllByCap(capability string) ([]plugingetter.CompatPlugin, error) { result := make([]plugingetter.CompatPlugin, 0, 1)