diff --git a/Dockerfile b/Dockerfile index b021eff686..906c76e61e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -25,7 +25,7 @@ # ARG CROSS="false" -ARG GO_VERSION=1.12.7 +ARG GO_VERSION=1.12.8 ARG DEBIAN_FRONTEND=noninteractive FROM golang:${GO_VERSION}-stretch AS base diff --git a/Dockerfile.e2e b/Dockerfile.e2e index 2ca7b4fb31..4505392091 100644 --- a/Dockerfile.e2e +++ b/Dockerfile.e2e @@ -1,4 +1,4 @@ -ARG GO_VERSION=1.12.7 +ARG GO_VERSION=1.12.8 FROM golang:${GO_VERSION}-alpine AS base diff --git a/Dockerfile.simple b/Dockerfile.simple index ff64fa4f54..b2ccfa4bf0 100644 --- a/Dockerfile.simple +++ b/Dockerfile.simple @@ -5,7 +5,7 @@ # This represents the bare minimum required to build and test Docker. -ARG GO_VERSION=1.12.7 +ARG GO_VERSION=1.12.8 FROM golang:${GO_VERSION}-stretch diff --git a/Dockerfile.windows b/Dockerfile.windows index c432186cc0..52c0c9b289 100644 --- a/Dockerfile.windows +++ b/Dockerfile.windows @@ -165,7 +165,7 @@ FROM microsoft/windowsservercore # Use PowerShell as the default shell SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] -ARG GO_VERSION=1.12.7 +ARG GO_VERSION=1.12.8 # Environment variable notes: # - GO_VERSION must be consistent with 'Dockerfile' used by Linux. diff --git a/TESTING.md b/TESTING.md index ba5bcda289..613c1b6435 100644 --- a/TESTING.md +++ b/TESTING.md @@ -115,5 +115,5 @@ You can change a version of golang used for building stuff that is being tested by setting `GO_VERSION` variable, for example: ``` -make GO_VERSION=1.12.7 test +make GO_VERSION=1.12.8 test ``` diff --git a/opts/hosts_test.go b/opts/hosts_test.go index 8c54ec0f4b..7a0a943adf 100644 --- a/opts/hosts_test.go +++ b/opts/hosts_test.go @@ -53,8 +53,8 @@ func TestParseHost(t *testing.T) { func TestParseDockerDaemonHost(t *testing.T) { invalids := map[string]string{ - "tcp:a.b.c.d": "Invalid bind address format: tcp:a.b.c.d", - "tcp:a.b.c.d/path": "Invalid bind address format: tcp:a.b.c.d/path", + "tcp:a.b.c.d": "", + "tcp:a.b.c.d/path": "", "udp://127.0.0.1": "Invalid bind address format: udp://127.0.0.1", "udp://127.0.0.1:2375": "Invalid bind address format: udp://127.0.0.1:2375", "tcp://unix:///run/docker.sock": "Invalid proto, expected tcp: unix:///run/docker.sock", @@ -83,7 +83,7 @@ func TestParseDockerDaemonHost(t *testing.T) { "localhost:5555/path": "tcp://localhost:5555/path", } for invalidAddr, expectedError := range invalids { - if addr, err := parseDaemonHost(invalidAddr); err == nil || err.Error() != expectedError { + if addr, err := parseDaemonHost(invalidAddr); err == nil || expectedError != "" && err.Error() != expectedError { t.Errorf("tcp %v address expected error %q return, got %q and addr %v", invalidAddr, expectedError, err, addr) } } @@ -99,8 +99,8 @@ func TestParseTCP(t *testing.T) { defaultHTTPHost = "tcp://127.0.0.1:2376" ) invalids := map[string]string{ - "tcp:a.b.c.d": "Invalid bind address format: tcp:a.b.c.d", - "tcp:a.b.c.d/path": "Invalid bind address format: tcp:a.b.c.d/path", + "tcp:a.b.c.d": "", + "tcp:a.b.c.d/path": "", "udp://127.0.0.1": "Invalid proto, expected tcp: udp://127.0.0.1", "udp://127.0.0.1:2375": "Invalid proto, expected tcp: udp://127.0.0.1:2375", } @@ -125,7 +125,7 @@ func TestParseTCP(t *testing.T) { "localhost:5555/path": "tcp://localhost:5555/path", } for invalidAddr, expectedError := range invalids { - if addr, err := ParseTCPAddr(invalidAddr, defaultHTTPHost); err == nil || err.Error() != expectedError { + if addr, err := ParseTCPAddr(invalidAddr, defaultHTTPHost); err == nil || expectedError != "" && err.Error() != expectedError { t.Errorf("tcp %v address expected error %v return, got %s and addr %v", invalidAddr, expectedError, err, addr) } }