kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

registry: remove accidentally added --insecure-registry feature 

If `--insecure-registry mydomain.com` was specified, it would match a registry at mydomain.com on any port.
This was accidentally added in #9735 and is now being reverted.

Signed-off-by: Tibor Vass <teabee89@gmail.com>
This commit is contained in:
Tibor Vass 2014-12-19 16:40:28 -05:00
parent 0874f9ab77
commit 9a50dd5f37
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
registry/endpoint.go
View File

@ -190,7 +190,7 @@ func isSecure(hostname string, insecureRegistries []string) (bool, error) {
}
for _, r := range insecureRegistries {
if hostname == r || host == r {
if hostname == r {
// hostname matches insecure registry
return false, nil
}

3
registry/registry_test.go
View File

@ -350,7 +350,8 @@ func TestIsSecure(t *testing.T) {
{"42.42.42.42:5000", []string{"42.1.1.1/8"}, false},
{"invalid.domain.com", []string{"42.42.0.0/16"}, true},
{"invalid.domain.com", []string{"invalid.domain.com"}, false},
{"invalid.domain.com:5000", []string{"invalid.domain.com"}, false},
{"invalid.domain.com:5000", []string{"invalid.domain.com"}, true},
{"invalid.domain.com:5000", []string{"invalid.domain.com:5000"}, false},
}
for _, tt := range tests {
// TODO: remove this once we remove localhost insecure by default