From 9dde8f2b46043353fdb798318b4b28903cdd4aff Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 11 Oct 2019 13:15:01 +0200 Subject: [PATCH] hack/validate/deprecate-integration-cli: don't exit on success The `hack/validate/deprecate-integration-cli` script exited on success. As a result, validation steps to run afterwards would not be executed. Signed-off-by: Sebastiaan van Stijn --- hack/validate/deprecate-integration-cli | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hack/validate/deprecate-integration-cli b/hack/validate/deprecate-integration-cli index bc20bf9f75..07a0628778 100755 --- a/hack/validate/deprecate-integration-cli +++ b/hack/validate/deprecate-integration-cli @@ -9,17 +9,17 @@ new_tests=$( grep -E '^\+func (.*) Test' || true ) -if [ -z "$new_tests" ]; then +if [ -n "$new_tests" ]; then + { + echo "The following new tests were added to integration-cli:" + echo + echo "$new_tests" + echo + echo "integration-cli is deprecated. Please add an API integration test to" + echo "./integration/COMPONENT/. See ./TESTING.md for more details." + echo + } >&2 + false +else echo 'Congratulations! No new tests added to integration-cli.' - exit fi - -echo "The following new tests were added to integration-cli:" -echo -echo "$new_tests" -echo -echo "integration-cli is deprecated. Please add an API integration test to" -echo "./integration/COMPONENT/. See ./TESTING.md for more details." -echo - -exit 1