From 8f65bb6d90e3a95420bb634e415c3cce36d86201 Mon Sep 17 00:00:00 2001 From: Boaz Shuster Date: Wed, 6 Dec 2017 16:45:33 +0200 Subject: [PATCH] Add a debug message when client closes websocket attach connection When the client closes websocket connections that sends container output through websocket, an error message is displayed: "Error attaching websocket: %!s()" This message is misleading. Thus, this change suggests to check if error is nil and print the correct message accordingly. Signed-off-by: Boaz Shuster --- api/server/router/container/container_routes.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/api/server/router/container/container_routes.go b/api/server/router/container/container_routes.go index d845fdd00f..b7848a3c94 100644 --- a/api/server/router/container/container_routes.go +++ b/api/server/router/container/container_routes.go @@ -593,7 +593,11 @@ func (s *containerRouter) wsContainersAttach(ctx context.Context, w http.Respons close(done) select { case <-started: - logrus.Errorf("Error attaching websocket: %s", err) + if err != nil { + logrus.Errorf("Error attaching websocket: %s", err) + } else { + logrus.Debug("websocket connection was closed by client") + } return nil default: }