mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Merge pull request #10520 from dmcgowan/v2-registry-fallback-logging
This commit is contained in:
commit
a0a27e6a58
2 changed files with 6 additions and 2 deletions
|
@ -86,7 +86,7 @@ func (s *TagStore) CmdPull(job *engine.Job) engine.Status {
|
||||||
log.Errorf("Error logging event 'pull' for %s: %s", logName, err)
|
log.Errorf("Error logging event 'pull' for %s: %s", logName, err)
|
||||||
}
|
}
|
||||||
return engine.StatusOK
|
return engine.StatusOK
|
||||||
} else if err != registry.ErrDoesNotExist {
|
} else if err != registry.ErrDoesNotExist && err != ErrV2RegistryUnavailable {
|
||||||
log.Errorf("Error from V2 registry: %s", err)
|
log.Errorf("Error from V2 registry: %s", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -374,6 +374,10 @@ type downloadInfo struct {
|
||||||
func (s *TagStore) pullV2Repository(eng *engine.Engine, r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, tag string, sf *utils.StreamFormatter, parallel bool) error {
|
func (s *TagStore) pullV2Repository(eng *engine.Engine, r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, tag string, sf *utils.StreamFormatter, parallel bool) error {
|
||||||
endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
|
endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if repoInfo.Index.Official {
|
||||||
|
log.Debugf("Unable to pull from V2 registry, falling back to v1: %s", err)
|
||||||
|
return ErrV2RegistryUnavailable
|
||||||
|
}
|
||||||
return fmt.Errorf("error getting registry endpoint: %s", err)
|
return fmt.Errorf("error getting registry endpoint: %s", err)
|
||||||
}
|
}
|
||||||
auth, err := r.GetV2Authorization(endpoint, repoInfo.RemoteName, true)
|
auth, err := r.GetV2Authorization(endpoint, repoInfo.RemoteName, true)
|
||||||
|
|
|
@ -284,7 +284,7 @@ func (s *TagStore) pushV2Repository(r *registry.Session, eng *engine.Engine, out
|
||||||
endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
|
endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if repoInfo.Index.Official {
|
if repoInfo.Index.Official {
|
||||||
log.Infof("Unable to push to V2 registry, falling back to v1: %s", err)
|
log.Debugf("Unable to push to V2 registry, falling back to v1: %s", err)
|
||||||
return ErrV2RegistryUnavailable
|
return ErrV2RegistryUnavailable
|
||||||
}
|
}
|
||||||
return fmt.Errorf("error getting registry endpoint: %s", err)
|
return fmt.Errorf("error getting registry endpoint: %s", err)
|
||||||
|
|
Loading…
Reference in a new issue