kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

daemon/start: Revert passing ctx to ctr.Start 

This caused integration tests to timeout in the CI

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This commit is contained in:
Paweł Gronowski 2022-10-27 10:40:03 +02:00
parent def549c8f6
commit a181a825c8
No known key found for this signature in database
GPG Key ID: B85EFCFE26DEF92A
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
daemon/start.go
View File

@ -183,8 +183,8 @@ func (daemon *Daemon) containerStart(ctx context.Context, container *container.C
}
// TODO(mlaventure): we need to specify checkpoint options here
tsk, err := ctr.Start(ctx, checkpointDir,
container.StreamConfig.Stdin() != nil || container.Config.Tty,
tsk, err := ctr.Start(context.TODO(), // Passing ctx to ctr.Start caused integration tests to be stuck in the cleanup phase
checkpointDir, container.StreamConfig.Stdin() != nil || container.Config.Tty,
container.InitializeStdio)
if err != nil {
if err := ctr.Delete(context.Background()); err != nil {